rt400/jewish-sabbaths-holidays

Jewish Shabbat Yomtov and Holidays times and event

jewish-sabbaths-holidays's Issues

It works!

(Not strictly shomer Shabbat but married to someone who is)

I've been waiting all week to see if the binary sensor works and (more importantly!) whether my simple False -> True "if" condition (for triggering the start of all my Shabbat automations) would work.

A few screenshots based on the binary sensor:

My trigger:

Does this:

... which then changes lights, etc.

The logging functions in Home Assistant aren't bad:

Just in case I had a little monitoring dashboard configured:

Thanks for developing this and Shabbat Shalom!

הוספת "zmanim"

היי,
תודה על עבודתך אני משתמש בזה הרבה.
יש אפשרות להוסיף גם את "zmanim" מתוך hebcal?
לצורך מידע על תחילת וסיום צומות

תודה על הכל

Differances from Jewish Calendar Integration

I currently use the Jewish calendar integration, how is this different? if there are any pros i would love to switch.

Hacs - can't find

Hi I cant find your repository at the hacs

"No Info" on is_yomtov

Hi,
First of all, thanks for this integration

I think the current response for is_yomtov ("No Info") is not good. I would hope to get False.

1. Can you explain the current behavior and whether this is intentional?
2. Do you think we can change it so No Info - would be False instead?

If your answer to 2 is yes, I would love to try and open a PR for this change and contribute my first contribution for the HASS community

Thanks

Error in counting the Omer

It worked great for me until today, I started receiving a message during the Omer count that there is no Omer count, what could be the problem?

Some sensors are pulling info - others are not

Hi

Some of the sensors work - other's don't. I have the configuration files set up in Configuration.yaml and the Latitude and longitude are NOT set up ip the configuration.Yaml. TheyL&L and TimeZone are set up properly in the General Tab from my original install. For some reason - it's not being picked up correctly.

The following code is showing up in the Hebcal_data_full.json

        "city": "32°11′N 35°0′E Asia/Jerusalem",
        "latitude": 32.19961974235943,
        "longitude": 35.011625289917,
        "title": "32°11′N 35°0′E Asia/Jerusalem",
        "tzid": "Asia/Jerusalem"

Daf Yomi - Shows up fine
Mincha - Invalid timestamp
Candle Lighting - Invalid timestamp

One request for help (30 minutes until Shabbat time)

Hey!

Hope it's okay to drop in here with a quick request for help if anyone can offer it.

I'd like to create a notification for when it's 30 minutes until Shabbat.

I'm guessing that the logical sensor to poll for the timestamp is:

sensor.jewish_calendar_upcoming_candle_lighting

Has anyone figured out a clever way to trigger an automation based on an amount of time preceding that (like in my case 30 minutes)?

TIA

sensor.hebcal_is_yomtov returns "No Info"

Current sensor condition for "is_yomtov" returns "No info".

Is the integration broken? (I assume it's supposed to be the same True/False flag as is_shabbat).

If not perhaps it could be changed to True/False for ease of use and configuring automations.

Isur melacha sensor

I understand and love the separation you made between shabbat and yomtov, and it's indeed helpful.
Still, I sometime do find myself adding "and" condition that checking if it's not shabbat and not yomtov.
Do you think there is a place to another sensor represent this condition (isur melacha or whatever other name you'll decide to call it)

If so, I would love to try and open a PR for this change and contribute

Thanks

Trying to get started with this...

Hi!

If anyone has a moment to help me try to get this setup, I would be very grateful.

I installed the integration through HACS and verified that the custom component directory is created as expected.

I added the boilerplate text to my configuration.yaml:

However, I can't see any entities that have been created:

Could anyone let me know what I've done wrong?

Typo in suggested config file on homepage

Hey - just FYI as people (like me!) might copy and paste the default config file on the homepage into their configuration.yaml and if they do they'll end up without the add-on because jerusalem_candle chokes it (you have jerualem_candle rather than jerusalem_candle):

Many thanks for making this!

Jerusalmem candle light

When adding:
jerusalem_candle: True to the yaml configuration file
the integration stops working

Traceback

Hi

Excited about this integration. Unfortunately, I can't get any of the sensors to work. Here is a sample from the log file

2021-06-27 23:44:01 ERROR (MainThread) [homeassistant.helpers.entity] Update for sensor.hebcal_hebrew_date fails
Traceback (most recent call last):
File "/config/custom_components/hebcal/sensor.py", line 229, in create_db_file
await self.filter_db(temp_db["items"], "new")
File "/config/custom_components/hebcal/sensor.py", line 271, in filter_db
is_in = datetime.datetime.strptime(
File "/usr/local/lib/python3.8/_strptime.py", line 568, in _strptime_datetime
tt, fraction, gmtoff_fraction = _strptime(data_string, format)
File "/usr/local/lib/python3.8/_strptime.py", line 352, in _strptime
raise ValueError("unconverted data remains: %s" %
ValueError: unconverted data remains: -04:00
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 350, in async_update_ha_state
await self.async_device_update()
File "/usr/src/homeassistant/homeassistant/helpers/entity.py", line 558, in async_device_update
raise exc
File "/config/custom_components/hebcal/sensor.py", line 171, in async_update
await self.update_db()
File "/config/custom_components/hebcal/sensor.py", line 389, in update_db
await self.create_db_file()
File "/config/custom_components/hebcal/sensor.py", line 238, in create_db_file
with open(
FileNotFoundError: [Errno 2] No such file or directory: '/config/custom_components/hebcal/hebcal_data.json

What are the differences between this and the built-in jewish_calendar?

it wasn't clear to me from the README what advantages this offers (HebCal vs hdate, I guess... but so what?) the built in jewish_calendar integration

שגיאה בפרטי שבת (17.7.21)

אני מניח שניתן לפנות אליך בעברית.
זה מה שמתקבל לגבי השבת הקרובה:
"פרשת דְּבָרִים , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן , שַׁבָּת חֲזוֹן"

Hebrew/English

Hi I’ve just installed this on my HA. Seems to work well, but the sensors are returning in Hebrew. Is there any way to get English values?

Warning in log

Since latest version logs show warnings regarding your excellent integration

`
Logger: homeassistant.helpers.entity
Source: helpers/entity.py:554
First occurred: 00:40:43 (6 occurrences)
Last logged: 00:40:43

Entity sensor.hebcal_is_shabbat (<class 'custom_components.hebcal.sensor.Hebcal'>) is using self.async_update_ha_state(), without enabling force_update. Instead it should use self.async_write_ha_state(), please report it to the custom integration author.
Entity sensor.hebcal_parasha (<class 'custom_components.hebcal.sensor.Hebcal'>) is using self.async_update_ha_state(), without enabling force_update. Instead it should use self.async_write_ha_state(), please report it to the custom integration author.
Entity sensor.hebcal_shabbat_entry (<class 'custom_components.hebcal.sensor.Hebcal'>) is using self.async_update_ha_state(), without enabling force_update. Instead it should use self.async_write_ha_state(), please report it to the custom integration author.
Entity sensor.hebcal_event_name (<class 'custom_components.hebcal.sensor.Hebcal'>) is using self.async_update_ha_state(), without enabling force_update. Instead it should use self.async_write_ha_state(), please report it to the custom integration author.
Entity sensor.hebcal_shabbat_came_out (<class 'custom_components.hebcal.sensor.Hebcal'>) is using self.async_update_ha_state(), without enabling force_update. Instead it should use self.async_write_ha_state(), please report it to the custom integration author.
`