Comments (17)
@sagarnasit The add to the home screen just needs the icon to be present in the theme directory which is already specified in readme. The PWA plugin already creates the manifest file we do not need to create a manifest file.
from pwa-extension.
Please add your estimate here for this issue.
You need to add the detailed desc for the work done on a day either on AC time entry description or GH issue that you are working on.
from pwa-extension.
@deepaklalwani97 @kiranpotphode
Let's do collaborative work here.
Anyone can pick the Unit Testing setup from here and merge it to the repo, so it can have common base to start with - rtCamp/login-with-google#19
Then pick the classes and post a comment here that you are picking this class. So another folk can pick the next class to start with.
This will speed up the work and it will help speed it up.
Do follow the peer reviews for the PRs to make it more similar between your work
from pwa-extension.
Please create all these PRs against the dev-unit-test
(create from master) branch. Make sure that we'll have one PR from dev-unit-test
to master for all together
from pwa-extension.
@DevikVekariya I have already written 2 out of 3 tests for the classes. I am working on third class and facing some issue loading the depending plugin in the test environment so this issue might take 4-5 more hours approx.
from pwa-extension.
@DevikVekariya Can you help me with the GH_bot_token and vault_token for this repository I do not have access and not sure how to generate it.
from pwa-extension.
@DevikVekariya The PHPCS and PHPUnit actions are set up and running.
from pwa-extension.
@deepaklalwani97 @kiranpotphode
Please schedule merging this PR tomorrow. #20
@sagarnasit please help test one time.
from pwa-extension.
@deepaklalwani97 What are the steps needed for add to home screen? I followed readme for adding icon in theme but it didn't work for me.
from pwa-extension.
The add to home screen does not work with our dev sites because of Http auth the web app manifest throws 401 error so I have tested this on different 000host site.
from pwa-extension.
@deepaklalwani97 Can you add proper readme for add to home screen
feature. If it require manifest file then please mention steps for that. Different device may support different size icons there for please mention that too or you can provide link for detailed references.
from pwa-extension.
@sagarnasit Is this #26 tested from your side. Can we merge this now? Please confirm.
from pwa-extension.
Why #26 has to be tested by sagar? @deepaklalwani97
from pwa-extension.
@DevikVekariya It is tested from my side to just asking @sagarnasit to confirm.
from pwa-extension.
@DevikVekariya As the offline form is in a separate issue and there is no update needed in this PR we can merge it or get it tested by QA.
from pwa-extension.
Tested the Add to Screen and Offline reading feature and it works as expected.
On mobile device Add to Homescreen option was visible and the visited pages are also getting cached.
On desktop an +
icon was shown in the address bar checked installing the app through it and checked the offline reading feature and it works. Also, only the visited pages are available for offline reading.
from pwa-extension.
Closing this issue as the unit tests are merged to the master.
from pwa-extension.
Related Issues (12)
- Utilize site icon customizer option for PWA icon HOT 3
- [PWA] Precache site assets and current page HOT 2
- Navigation preload is continuously reloading when offline HOT 2
- Development and contribution workflow HOT 1
- [PWA] Push notification plugins support HOT 4
- Conflicts with iZooto plugin HOT 8
- Gravity form submission does not work if the current form URL is added in the menu HOT 5
- Remove some features in favor of the official pwa plugin
- [PWA] Disable workbox console messages HOT 6
- [PWA] Offline Google Analytics HOT 4
- [PWA] Precache active menu pages when the site is accessed. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pwa-extension.