Comments (6)
The self.__WB_DISABLE_DEV_LOGS
constant check for disabling logs is available from the 5.0 workbox version and the PWA plugin currently uses 4.3.1. So adding this constant in the service worker will not work until the workbox version is updated in the PWA plugin.
from pwa-extension.
The version of workbox is updated in the alpha version of the PWA plugin. I have tested on that alpha version and adding self.__WB_DISABLE_DEV_LOGS = true; disables the workbox logs properly.
from pwa-extension.
PR for this issue blocked because of #6 (comment)
from pwa-extension.
This we will keep open until the Workbox updates to latest version in PWA plugin.
In blocked status.
from pwa-extension.
The latest version of PWA by default disables the dev logs and Setting WP_SERVICE_WORKER_DEBUG_LOG
to true enables the dev log. So no code change is required in our plugin and this issue can be closed.
CC:- @pradeep910 @DevikVekariya
from pwa-extension.
Correct. Closing this as new release of PWA plugin has latest Workbox JS which solves this issue.
from pwa-extension.
Related Issues (12)
- Utilize site icon customizer option for PWA icon HOT 3
- [PWA] Precache site assets and current page HOT 2
- Setup and add unit test cases HOT 17
- Navigation preload is continuously reloading when offline HOT 2
- Development and contribution workflow HOT 1
- [PWA] Push notification plugins support HOT 4
- Conflicts with iZooto plugin HOT 8
- Gravity form submission does not work if the current form URL is added in the menu HOT 5
- Remove some features in favor of the official pwa plugin
- [PWA] Offline Google Analytics HOT 4
- [PWA] Precache active menu pages when the site is accessed. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pwa-extension.