Giter Site home page Giter Site logo

Comments (6)

deepaklalwani97 avatar deepaklalwani97 commented on June 25, 2024

The self.__WB_DISABLE_DEV_LOGS constant check for disabling logs is available from the 5.0 workbox version and the PWA plugin currently uses 4.3.1. So adding this constant in the service worker will not work until the workbox version is updated in the PWA plugin.

from pwa-extension.

deepaklalwani97 avatar deepaklalwani97 commented on June 25, 2024

The version of workbox is updated in the alpha version of the PWA plugin. I have tested on that alpha version and adding self.__WB_DISABLE_DEV_LOGS = true; disables the workbox logs properly.

from pwa-extension.

deepaklalwani97 avatar deepaklalwani97 commented on June 25, 2024

PR for this issue blocked because of #6 (comment)

from pwa-extension.

pradeep910 avatar pradeep910 commented on June 25, 2024

This we will keep open until the Workbox updates to latest version in PWA plugin.
In blocked status.

from pwa-extension.

deepaklalwani97 avatar deepaklalwani97 commented on June 25, 2024

The latest version of PWA by default disables the dev logs and Setting WP_SERVICE_WORKER_DEBUG_LOG to true enables the dev log. So no code change is required in our plugin and this issue can be closed.
CC:- @pradeep910 @DevikVekariya

from pwa-extension.

pradeep910 avatar pradeep910 commented on June 25, 2024

Correct. Closing this as new release of PWA plugin has latest Workbox JS which solves this issue.

from pwa-extension.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.