rtucker/munin-lighttpd

A Munin plugin to monitor lighttpd statistics

munin-lighttpd's Issues

lighttpd_ instead of lighttpd

What about renaming the script to end it's name with an underscore as many other munin plugins do to indicate that they expect a parameter given? It's just a convention but a useful one I think.

Create a README file

A README file would be beneficial.

Graphing /server-counters

Would it be possible to add support for graphing load, requests, requests_failed and backlogged from /server-counters?

proxy-core.0.backends."unix:/var/run/chowder/defender.sock".load: 0
proxy-core.0.backends."unix:/var/run/chowder/defender.sock".pool_size: 0
proxy-core.0.backends."unix:/var/run/chowder/defender.sock".requests: 352
proxy-core.0.backends."unix:/var/run/chowder/defender.sock".requests_failed: 0
proxy-core.0.backlogged: 0
proxy-core.1.backends."unix:/var/run/chowder/cinemobile.sock".load: 0
proxy-core.1.backends."unix:/var/run/chowder/cinemobile.sock".pool_size: 0
proxy-core.1.backends."unix:/var/run/chowder/cinemobile.sock".requests: 3
proxy-core.1.backends."unix:/var/run/chowder/cinemobile.sock".requests_failed: 0
proxy-core.1.backlogged: 0
proxy-core.requests: 355

If I have some time over the weekend I might be able to look at implementing it myself but I'm not too familiar with python.

Status URL fix

STATUS_URL = os.environ.get('statusurl', 'http://127.0.0.1/server-status?auto')

So that you can change in your munin config file

[lighttpd_*]
env.statusurl http://ip/other_status

Ref:
http://redmine.lighttpd.net/projects/lighttpd-sandbox/wiki/Howto_Munin

plugins work when run from the command-line but fail through munin

2012/10/13-07:20:04 [945] Service 'lighttpd_idleservers' exited with status 1/0.
2012/10/13-07:20:04 [945] Error output from lighttpd_kbytes:
2012/10/13-07:20:04 [945] Traceback (most recent call last):
2012/10/13-07:20:04 [945] File "/etc/munin/plugins/lighttpd_kbytes", line 111, in
2012/10/13-07:20:04 [945] print_status(param, STATUS_URL)
2012/10/13-07:20:04 [945] File "/etc/munin/plugins/lighttpd_kbytes", line 70, in print_status
2012/10/13-07:20:04 [945] key, value = i.split(':')
2012/10/13-07:20:04 [945] ValueError: need more than 1 value to unpack
2012/10/13-07:20:04 [945] Service 'lighttpd_kbytes' exited with status 1/0.

This happens on all of them although for lighttpd_uptime:

2012/10/13-07:20:04 [945] Service 'lighttpd_uptime' exited with status 1/0.
2012/10/13-07:20:05 [945] Error output from memory_by_process:
2012/10/13-07:20:05 [945] Can't open perl script "
2012/10/13-07:20:05 [945] $junk = <>;
2012/10/13-07:20:05 [945] while (<>)
2012/10/13-07:20:05 [945] {
2012/10/13-07:20:05 [945] @A = split;
2012/10/13-07:20:05 [945] $proc = $a[10];
2012/10/13-07:20:05 [945] $proc =~ s|./||;
2012/10/13-07:20:05 [945] $proc =~ s/:.//;
2012/10/13-07:20:05 [945] $proc =~ tr/[]//d;
2012/10/13-07:20:05 [945] $proc =~ tr/A-Za-z0-9//c;
2012/10/13-07:20:05 [945] $vsz = $a[4];
2012/10/13-07:20:05 [945] $total{$proc} += $vsz;
2012/10/13-07:20:05 [945] }
2012/10/13-07:20:05 [945] my $stack = 0;
2012/10/13-07:20:05 [945] sub draw() { return $stack++ ? "STACK" : "AREA" }
2012/10/13-07:20:05 [945] print map
2012/10/13-07:20:05 [945] {
2012/10/13-07:20:05 [945] "$.label $\n" .
2012/10/13-07:20:05 [945] "$.min 0\n" .
2012/10/13-07:20:05 [945] "$.draw " . draw() . "\n" .
2012/10/13-07:20:05 [945] "$.cdef $_,1024,*\n"
2012/10/13-07:20:05 [945] }
2012/10/13-07:20:05 [945] sort keys %total;
2012/10/13-07:20:05 [945] ": No such file or directory

I'm not sure why this is happening; any clues?

bad exit from telnet but successful via command line

On FreeBSD 9.0-RELEASE with munin 1.4.7 I can successfully execute lighttpd_ from the command line:

python lighttpd_kbytes 
data.value 56964

However no graphs are being generated and when I try it via telnet I encounter the following:

telnet localhost 4949
Trying 127.0.0.1...
Connected to localhost.
Escape character is '^]'.
# munin node at xsgames01-dev
fetch lighttpd_kbytes
# Bad exit
.

From /var/log/munin/munin-node.log:

2012/09/04-15:04:22 CONNECT TCP Peer: "[127.0.0.1]:14975" Local: "[127.0.0.1]:4949"
Use of uninitialized value in pattern match (m//) at /usr/local/lib/perl5/site_perl/5.16.0/Net/Server.pm line 600.
2012/09/04-15:04:28 [20268] Error output from lighttpd_kbytes:
2012/09/04-15:04:28 [20268]     Can't exec "/usr/local/etc/munin/plugins/lighttpd_kbytes": No such file or directory at /usr/local/lib/perl5/site_perl/5.16.0/Munin/Node/Service.pm line 215, <STDIN> line 1.
2012/09/04-15:04:28 [20268]     # ERROR: Failed to exec.
2012/09/04-15:04:28 [20268] Service 'lighttpd_kbytes' exited with status 42/0.

The odd part is this occurs on two machines which are identical (production and development) but I have a 2nd set of machines with the same services and version of FreeBSD running that does not have this issue.

/usr/local/etc/munin/plugins:

lrwxr-xr-x  1 0  0  40 Sep  4 14:03 lighttpd_accesses -> /usr/local/share/munin/plugins/lighttpd_
lrwxr-xr-x  1 0  0  40 Sep  4 14:03 lighttpd_busyservers -> /usr/local/share/munin/plugins/lighttpd_
lrwxr-xr-x  1 0  0  40 Sep  4 14:03 lighttpd_idleservers -> /usr/local/share/munin/plugins/lighttpd_
lrwxr-xr-x  1 0  0  40 Sep  4 14:03 lighttpd_kbytes -> /usr/local/share/munin/plugins/lighttpd_
lrwxr-xr-x  1 0  0  40 Sep  4 14:03 lighttpd_uptime -> /usr/local/share/munin/plugins/lighttpd_

/usr/local/share/munin/plugins:

-rwxr-xr-x  1 0  0  4127 Sep  4 14:03 /usr/local/share/munin/plugins/lighttpd_