Condition can be a single instruction

[rubberduck-vba]

Condition can be a single instruction

[rubberduck203]

When configuring, I believe #25 and #28 are mutually exclusive. Otherwise, you "correct" the code only to receive another warning. That's confusing for an end user.

[retailcoder]

Not sure. Suggestions are, after all, suggestions. ReSharper does that too - it can suggest to use explicit type declaration on a var declaration, and then to use implicit type declaration; it's up to the user to determine which is best in that context... although making them mutually exclusive can help enforce consistency; let's make all code inspections enabled by default, and let the user configure them and determine which one(s) to deactivate.

[retailcoder]

This inspection + quickfix requires implementing a specialized If block analyzer.

[ThunderFrame]

meh, I don't like single line If statements in VBA.

You could take this inspection further and create inline If Else statements, but I like those even less.

• They make eyeballing the code more difficult, you have to check the entire If statement to check it is/isn't an inline If.

• Adding a second statement to the If, requires multiple operations, whereas a block If just requires a carriage return.