Giter Site home page Giter Site logo

Comments (10)

rubenkaiser avatar rubenkaiser commented on August 22, 2024 2

[email protected] was just released and can be used with serverless-offline > 10.0.0

from serverless-offline-eventbridge.

rubenkaiser avatar rubenkaiser commented on August 22, 2024 1

Unfortunately the new version of Serverless-offline does not export the required lambda files. There are several serverless-offline packages that are not working anymore. I'm keeping an eye on the following thread: CoorpAcademy/serverless-plugins#217

from serverless-offline-eventbridge.

rubenkaiser avatar rubenkaiser commented on August 22, 2024 1

@davidgarvie considering the amount of downloads nowadays I will start using the released as well. Good suggestion, thanks.

from serverless-offline-eventbridge.

mattensor avatar mattensor commented on August 22, 2024

Thanks @rubenkaiser

from serverless-offline-eventbridge.

rubenkaiser avatar rubenkaiser commented on August 22, 2024

I've just released a beta version 2.0.0-beta.0 in which I've put a bit of a hack to remove the serverless-offline export automatically. At this point serverless-offline may crash the first time but running it again should make it work.

For now this may fix your local env but I'm hoping they will remove the export themselves to solve this issue for all other plugins as well.

from serverless-offline-eventbridge.

mattensor avatar mattensor commented on August 22, 2024

🙏 Thank you @rubenkaiser!

from serverless-offline-eventbridge.

dnalborczyk avatar dnalborczyk commented on August 22, 2024

@rubenkaiser it was unbeknownst to me that other plugins were reaching into the lambda functionality of serverless-offline but it's the perfect thing to do. I was always hoping this would happen, albeit currently lacking documentation.

that said, I'm a bit surprised that instead of working around the package exports "problem", you wouldn't just file an issue with serverless-offline . we could have resolved this fairly quickly and early on 😉

I think the right thing to do would be instead of removing package exports altogether we would be either adding an additional export path to exports, or we would add a named export to index.js (which might be better). that way, stuff can be refactored inside the package, as long as the contract (which also officially doesn't exist [yet]) does not change. we would just need to define a contract and document it.

from serverless-offline-eventbridge.

rubenkaiser avatar rubenkaiser commented on August 22, 2024

You're right @dnalborczyk . I thought this issue was enough but now I see I never commented in your project. My bad. I think exporting an array of files is possible, however I saw that sqs for example is importing several things.

from serverless-offline-eventbridge.

rubenkaiser avatar rubenkaiser commented on August 22, 2024

PR for exporting the lambda code in a named export: dherault/serverless-offline#1552

from serverless-offline-eventbridge.

davidgarvie avatar davidgarvie commented on August 22, 2024

Thanks for the release @rubenkaiser, great work :) Have you considered tags / releases on github so the community has an easy way to get notified of new releases?

from serverless-offline-eventbridge.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.