rundeck-plugins/attribute-match-node-enhancer

node enhancer plugin to add icons and attributes (experimental)

attribute-match-node-enhancer's Issues

Icon plugin shows blank "Badges" section

When edit/creating instance of the Icon plugin, the "Badges" section is a blank area which cannot be modified.

Help needed - how to use

Hi,

we are trying to use this node enhancer in our setup, but it doesn't seem to do anything. We've put attribute-match-node-enhancer-0.1.3.jar under /var/lib/rundeck/libext, restarted Rundeck. Now we can define an "Attribute Match" under Project Settings -> Edit Nodes -> Enhancers.

Unfortunately the new attribute doesn't show up, when we are searching for the node. (Only the previously defined attributes are visible.)

Nodes are defined with the "URL Source" option and look like this:

As you can see, the attribute stage is defined as qa, so the Attribute Match should match and add the test_attribute.

Unfortunately we don't see any errors in the logs or even if the Attribute Match worked or not...

Can you please help?

Attribute Match Node Enhancer not accepting more than 1 line

Cannot add more than 1 line inside Attributes Match Node Enhancer.

1 from 7 nodes (Node: desktop-rd) has two attributes that should successfully match to add the new attribute to the only mentioned node (Resource Model Attributes: environment="STG" and region="SV").

If it's added more than one line in Attribute Matches, the node enhancer will not add the new attribute, in fact, it adds it to other nodes that don't have the environment="STG" and region="SV" attributes. Test below:

Also tested with delimiters like commas, space, or newline. None of this working.

To workaround this, create a unique attribute for the node (i.e: region_env="world_dev"). This way it can be added successfully the new attribute to the correct node only. Examples below:

Expected Behaviour:
Working with more than one attribute without creation of mixed/unique attributes or multiple additions of Match Attributes Node Enhancers.

Poor readibility due to Markdown not supported

Check how the help text is rendered below the first textarea:

How it should look like:

---

Attribute name/values to match. All matches must be met to add the additional attributes. Each entry should be of the form:

• key operator value

Where key is the attribute name, operator is one of:

• == equality match
• !! not present match
• =~ regular expression match
• != inequality match
• !~ negative regular expression match

---

attribute-match-node-enhancer/src/main/java/org/rundeck/plugins/nodes/attributes/AttributeNodeEnhancer.java

Line 29 in fffc024

"Attribute name/values to match. All matches must be met to add the additional attributes"

This might help with #1

Show stylised node icons in execution view

The icon node enhancer allows me to style the icons, supporting different icons and colours. These stylised icons show in the Nodes view and the Job view (list of target nodes) but not the Execution view.

Supporting the stylised icons in the Execution view would help for jobs which run against nodes of different attributes, the nodes are pre-selected, and the user doesn't have an intimate knowledge of those nodes. It could give the user some indication of what each node does. For example, web server or file server, depending on the icon, primary or standby depending on the colour.