rundfunk47/juice

A modern and simple JSON Encoder / Decoder for Swift 3

juice's Issues

Exception from deep within when decoding a derived class inside an object

Hi thanks for the updated version 1.0.9.

I just stumbled upon another issue with Juice.

I have a class B which inherits from a super class A:

class A: Juice.Decodable {
    var a: String?

    required init(fromJson json: Juice.JSONDictionary) throws {
        a = try? json.decode(["a"])
    }
}

class B: A {
    var b: String?

    required init(fromJson json: Juice.JSONDictionary) throws {
        b = try? json.decode(["b"])
        try super.init(fromJson: json)
    }
}

When I decode B (in my case an array of B's (not shown in this reduced example)) I get an exception from deep inside of Juice.

Example code:

        // Decoding simple object B -> Works
        do {
            let string = "{\"a\": \"Apple 0\", \"b\": \"Brother 0\"}"
            let dict = try toStrictlyTypedJSON(toLooselyTypedJSON(string)) as! JSONDictionary
            let o = try B(fromJson: dict)
            print(o.a, o.b)
        } catch {
            print(error.localizedDescription)
        }

        // B as a part of an object -> Fails
        do {
            let string = "{\"object\": {\"a\": \"Apple 1\", \"b\": \"Brother 1\"}}"
            let dict = try toStrictlyTypedJSON(toLooselyTypedJSON(string)) as! JSONDictionary

            // This works
            let oa: A = try dict.decode("object")
            print(oa.a)

            // This fails with exception "Could not cast value of type 'A' to 'B'"
            let ob: B = try dict.decode("object")
            print(ob.a, ob.b)
        } catch {
            print(error.localizedDescription)
        }

My knowledge of generics is a bit to shallow to find the reason.

All the best

null should be a valid type

{"a": "Apple 0", "b": null}

I get Juice.NotDecodableJSONError when trying to convert the string as follows:

let string = "{\"a\": \"Apple\", \"b\": null}"
let dict = try! toStrictlyTypedJSON(toLooselyTypedJSON(string)) as! JSONDictionary

A have verified the json with https://jsonformatter.curiousconcept.com/ and null is a valid type.

Parsing json number without decimal part into Double? fails

I receive runtimeHours as json to my app;

{
...
"runtimeHours": 1234,
...
}

In my model the value is an optional Double.
I found that my values always is nil using this code:

runtimeHours = try? json.decode(["runtimeHours"])

I thinks this is a bug, 1234 should be treated as a valid Double.

If I do try! instead the exception is:

Thread 1: Fatal error: 'try!' expression unexpectedly raised an error: Juice.DictionaryDecodingError(keyPath: ["runtimeHours"], underlyingError: Juice.MismatchError.typeMismatch(expected: Swift.Double, got: 1234))

Finally, my workaround now is this:

        if let intValue: Int = try? json.decode(["runtimeHours"]) {
            runtimeHours = Double(intValue)
        } else {
            runtimeHours = try? json.decode(["runtimeHours"])
        }

BTW, I like your pod a lot. Cheers.