Comments (5)
Before I switched from log to tracing for my project I would get this when attempting to unwrap the returned result in my user code. I came up with this monstrosity as a workaround. But this doesn't help now that it crashes internally in tracing.
/// Attempt to format the error in the best way possible.
///
/// Unfortunately this is awkward with dynamic Rune values.
fn try_format_error(phase: Phase, e: &rune::Value) -> anyhow::Result<()> {
match e.clone().into_any() {
rune::runtime::VmResult::Ok(any) => {
match any.clone().downcast_into_ref::<anyhow::Error>() {
Ok(err) => {
anyhow::bail!("Got error result from {phase}: {:?}", *err);
}
Err(err) => {
let ty = try_get_type_info(e, "error");
anyhow::bail!(
"Got error result from {phase}, but it was not an anyhow error: {err:?}, type info: {ty}: {any:?}",
);
}
}
}
rune::runtime::VmResult::Err(not_any) => {
tracing::error!("Got error result from {phase}, it was not an Any: {not_any:?}. Trying other approches at printing the error.");
}
}
// Attempt to format the error
let formatted = catch_unwind(AssertUnwindSafe(|| {
format!("Got error result from {phase}: {e:?}")
}));
match formatted {
Ok(str) => anyhow::bail!(str),
Err(_) => {
let ty = try_get_type_info(e, "error");
anyhow::bail!(
"Got error result from {phase}, but got a panic while attempting to format said error for printing, {ty}",
);
}
}
}
/// Best effort attempt at gettint the type info and printing it
fn try_get_type_info(e: &rune::Value, what: &str) -> String {
match e.type_info() {
rune::runtime::VmResult::Ok(ty) => format!("type info for {what}: {ty:?}"),
rune::runtime::VmResult::Err(err) => {
format!("failed getting type info for {what}: {err:?}")
}
}
}
from rune.
Well, Value
returns fmt::Error
if debug printing errors. For non-builtin values, this would be the case if it's called outside of a vm.
For some reason we've also opted to instrument the return value here. This is not correct and should be removed since formatting might fail.
It is convenient for Value
to implement fmt::Debug
, but maybe it shouldn't return fmt::Error
and instead debug print the errors that occurred to avoid issues like these. It's also a footgun since it definitely will not work unless called inside a vm externally with Vm::with
.
from rune.
It is convenient for
Value
to implementfmt::Debug
, but maybe it shouldn't returnfmt::Error
and instead debug print the errors that occurred to avoid issues like these. It's also a footgun since it definitely will not work unless called inside a vm externally withVm::with
.
My understanding is that std::fmt::Error is for when the formatting itself fails. And the Rust standard library will in fact panic in format!()
when this happen.
So if I understand you correctly and it error when printing an error (as opposed when to the formatting fails) this seems incorrect and like a misunderstanding.
from rune.
Yeah, we should fix it.
from rune.
I'll make a PR later today
from rune.
Related Issues (20)
- Flaky auto-formatting in vscode / Rune LSP crashes
- Broken auto-formatting for consecutive single line comments HOT 2
- Silly auto-formatting for chained method calls / builder pattern HOT 1
- Output capture on process in rune-modules is non-functional HOT 2
- Can not use vm_result on function taking `&mut self`
- Runes `std::collections::HashMap` is not accessible from rust extension types
- Missing docs for `#[rune::function(keep)]` HOT 2
- `#[rune::function]` fails when adding a 6th argument HOT 5
- Feature request: More accurate types in generated rune API documentation HOT 4
- New 0.13.x release? HOT 1
- Before releasing 0.14
- Rune LSP cargo broken with multi-binary crates HOT 2
- Formatting likes to add more and more blank lines (not idempotent) HOT 1
- request: Multiple match patterns
- Unwrap on Option is hard to use (moves value) HOT 1
- Formatting jank with comments at the trailing position in lists HOT 1
- Feature request: Raw string literals HOT 2
- Any::downcast_borrow_ref works with anyhow but not eyre HOT 2
- How to get Rune backtraces for native Results at runtime? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rune.