Giter Site home page Giter Site logo

Comments (4)

VorpalBlade avatar VorpalBlade commented on August 23, 2024 1

That was amazingly quick! Didn't even have time to start looking into doing it myself.

from rune.

udoprog avatar udoprog commented on August 23, 2024

Might be relatively straight forward albeit a bit tedious. You'd have to add the generic wherever they are referenced like here for the return type:

pub(crate) return_type: Option<Hash>,

And populate them from the context.

Finally you'd have to pass them into the link function here and modify it to take and recursively build links for generic parameters.

I'm thinking it might be appropriate to define a higher level type which captures both the base type and its generic parameters instead of just exposing a bare hash like we do now. Something like this:

#[cfg(feature = "doc")]
struct FullType {
    base: Option<Hash>,
    generics: Box<[Option<Hash>]>,
}

And then pass that into the link function, replacing any unknown Hash:es with ?.

from rune.

udoprog avatar udoprog commented on August 23, 2024

After landing #759, what we need to do next is to provide the necessary metadata through the MaybeTypeOf trait and pass it along so it can be used by the new context structures.

This also affects Any macro expansion.

from rune.

udoprog avatar udoprog commented on August 23, 2024

Cheers. Yeah, I think with #765 it's pretty much as good as it can be. Thanks for pointing this out!

from rune.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.