Comments (4)
That was amazingly quick! Didn't even have time to start looking into doing it myself.
from rune.
Might be relatively straight forward albeit a bit tedious. You'd have to add the generic wherever they are referenced like here for the return type:
rune/crates/rune/src/doc/context.rs
Line 41 in 7fd96d2
And populate them from the context.
Finally you'd have to pass them into the link function here and modify it to take and recursively build links for generic parameters.
I'm thinking it might be appropriate to define a higher level type which captures both the base type and its generic parameters instead of just exposing a bare hash like we do now. Something like this:
#[cfg(feature = "doc")]
struct FullType {
base: Option<Hash>,
generics: Box<[Option<Hash>]>,
}
And then pass that into the link
function, replacing any unknown Hash
:es with ?
.
from rune.
After landing #759, what we need to do next is to provide the necessary metadata through the MaybeTypeOf
trait and pass it along so it can be used by the new context structures.
This also affects Any
macro expansion.
from rune.
Cheers. Yeah, I think with #765 it's pretty much as good as it can be. Thanks for pointing this out!
from rune.
Related Issues (20)
- Flaky auto-formatting in vscode / Rune LSP crashes
- Broken auto-formatting for consecutive single line comments HOT 2
- Panic in rune-internal tracing logging while formatting anyhow `Result` wrapped in rune `Value` HOT 5
- Silly auto-formatting for chained method calls / builder pattern HOT 1
- Output capture on process in rune-modules is non-functional HOT 2
- Can not use vm_result on function taking `&mut self`
- Runes `std::collections::HashMap` is not accessible from rust extension types
- Missing docs for `#[rune::function(keep)]` HOT 2
- `#[rune::function]` fails when adding a 6th argument HOT 5
- New 0.13.x release? HOT 1
- Before releasing 0.14
- Rune LSP cargo broken with multi-binary crates HOT 2
- Formatting likes to add more and more blank lines (not idempotent) HOT 1
- request: Multiple match patterns
- Unwrap on Option is hard to use (moves value) HOT 1
- Formatting jank with comments at the trailing position in lists HOT 1
- Feature request: Raw string literals HOT 2
- Any::downcast_borrow_ref works with anyhow but not eyre HOT 2
- How to get Rune backtraces for native Results at runtime? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rune.