runeduniverse/r4m-maven-extension

Runes4Maven (r4m) Maven Extension provides an alternative way for defining maven executions

r4m-maven-extension's Issues

Dependencies: implement java-utils-maven

Goals

• move general tools to net.runeduniverse.lib.utils:utils-maven

Bug: External PEM Extensions not loading

PEM Extensions included in other (build-)extensions don't get loaded!

This bug is probably caused by r4m not searching additional extension realms for plexus artifacts

Patch Info: Eclipse Compatibility Error on "Update Project"

Eclipse Compatibility Error

Problem:

Eclipse on startup and every time you execute "Maven" > "Update Project" the execution will crash and report an internal error. However the error is not always the same!

Reason:

We traced the error back to eclipse. It seems that eclipse tries to extract information from the project and in doing so starts a clone of the official maven-core which does not provide all the dependencies that r4m requires!

Solution:

To resolve this issue we explicitly declared the dependency and scoped it as compile.

The fix will be deployed via the patch-version r4m-maven-extension: 1.0.1!

Should updating to >1.0.1 not fix the issue for you...

1. ... you will have to wipe out the older versions of this extension in your maven repository: Delete <user-home>/.m2/repository/net/runeduniverse/tools/maven/r4m/r4m-maven-extension.
2. ... you should restart your IDE (Eclipse)

Bug: Improper identification of other maven-extensions without goals

Problem:
When r4m finds an extension which is missing its PluginDescripter file the crash is only logged but not counted in it's R4MLifecycleParticipant.unidentifiablePlugins collection.

Operation is not influenced by this but causes considerable console spam!

Solution:
Extensions discovered via R4MLifecycleParticipant.scanCoreExtensions() should not get logged when missing their PluginDescripter file.

Feature: create atrifacts for model and model-builder

Goals

• split r4m-model from r4m-api
• split r4m-model-builder from r4m-maven-extension

So they are available as artifacts for other extensions / tools

Feature: Rework Phase Tasks

Rework Phase Tasks / Phase Ranges

Currently one is expected to define phases like +install.
This will be changed to install] to express "all phases in the lifecycle of before the in question".

Furthermore [install will be supported to express "all phases in the lifecycle of after the in question".

Another feature will be to define call on phases after a certain point.

For example:

The package] phase has been called previously and you want to finish the lifecycle but not deploy the artifact.
Now the phase-task package[,]deploy can be used.

Added Properties

r4m.lifecycle-task-request-calculator and r4m.lifecycle-task-request-calculator-on-fork

the two properties following values & effects:

declared: treats <phase> like [<phase>]

sequential: treats <phase> like <phase>]

Error with task range when Property is set

java.lang.StringIndexOutOfBoundsException when property r4m.lifecycle-task-request-calculator is set to sequential

executed task range is mvn clean install] -e

[ERROR] begin 0, end -1, length 5
java.lang.StringIndexOutOfBoundsException: begin 0, end -1, length 5
    at java.lang.String.checkBoundsBeginEnd (String.java:4606)
    at java.lang.String.substring (String.java:2709)
    at net.runeduniverse.tools.maven.r4m.lifecycle.SequentialLifecycleTaskReqCalcDelegate.splitEntries (SequentialLifecycleTaskReqCalcDelegate.java:76)
    at net.runeduniverse.tools.maven.r4m.lifecycle.DefaultLifecycleTaskReqCalcDelegate.calculateTaskRequest (DefaultLifecycleTaskReqCalcDelegate.java:51)
    at net.runeduniverse.tools.maven.r4m.lifecycle.AdvancedLifecycleExecutionPlanCalculator.calculateMojoExecutions (AdvancedLifecycleExecutionPlanCalculator.java:290)
    at net.runeduniverse.tools.maven.r4m.lifecycle.AdvancedLifecycleExecutionPlanCalculator.calculateExecutionPlan (AdvancedLifecycleExecutionPlanCalculator.java:166)
    at net.runeduniverse.tools.maven.r4m.lifecycle.AdvancedLifecycleExecutionPlanCalculator.calculateExecutionPlan (AdvancedLifecycleExecutionPlanCalculator.java:182)
    at org.apache.maven.lifecycle.internal.builder.BuilderCommon.resolveBuildPlan (BuilderCommon.java:98)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:111)
    at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
    at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
    at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:294)
    at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:960)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
[ERROR] 
[ERROR] Re-run Maven using the -X switch to enable full debug logging.

Feature: Mode & Execution Launch Parameters for Lifecycle Phases from CLI

Goals

make it easier to use and provide more cli options

Before

• A phase can be executed via a mode by running a phase which forks the phase.
  Basically only within a forked state
• Same behavior as for Modes applies for Execution evocation of phases
• Basic Maven sequential phase execution behavior can be called by prefix but spams available lifecycle phase output

sequential phase execution behavior:

mvn dev-<phase>

After

• Define a Mode by phase prefix
• Define an Execution by phase postfix
• Switch phase execution behavior with + flag before phase

mvn [<mode>/][+]<phase>[@<execution>]

Bug: Plugin <configuration> missing on active Profile

Plugin configuration doesn't get implemented when injecting with active profiles.