runelaenen/sw6-media-optimizer

Image Optimizer for Shopware 6 💙

sw6-media-optimizer's Issues

Feature Request,

Hello @runelaenen
Thanks for the great plugin. It makes live a much easier.

I`m asking if it is possible to add a new switch on the command to set the max width of a image.

So for example if the switch --max-midth is set then all images are first resized and then processed through the optimizer.
https://github.com/Intervention/image
This library could be used to resize the image.
I will try to implement the feature and then set up a pull request.

Issue for image 'hosting'

Media with missing file data (name, extension) stop command from further execution

Media Entities that are missing the file name or the file extension stop the command from execution.

Install via Zip does not work

Hi there,
I have SW 6.3.3.0 and installed your plugin via Zip upload (admin interface). When trying to use the command:

bin/console rl:media:optimize

it fails with the following exception:

In srcShopware_Production_KernelProdContainer.php line 16965:
                                                                                           
  Attempted to load class "OptimizerChainFactory" from namespace "Spatie\ImageOptimizer".  
  Did you forget a "use" statement for another namespace?         

Any idea to fix this?

support filesystem

The optimizing should respect the used filesystem.
Currently, it assumes using local storage.

Exception on empty filename (should be skipped)

Hey,
I'm currently facing a small issue - should be easy to fix (MediaOptimizeCommand.php#L158)

$ bin/console rl:media:optimize
  33/909 [=>--------------------------]   3%20:17:27 CRITICAL  [console] Error thrown while running command "rl:media:optimize". Message: "A valid Filename must be provided." ["exception" => Shopware\Core\Content\Media\Exception\EmptyMediaFilenameException^ { …},"command" => "rl:media:optimize","message" => "A valid Filename must be provided."]

In UrlGenerator.php line 136:
                                      
A valid Filename must be provided. 

If you need any further information, just let me know. (Btw. nice plugin!)

Cheers.

[edit]
Added linenumber and filename where the error is initially triggered.