runroom/runroom-packages

Runroom packages for Symfony development

runroom-packages's Issues

Use abstract entities instead of real entities

[RunroomSeoBundle] Implement more kind of extractors

There should be more ways to extract the context:

• Facade to add more ContextExtractors, like: canExtract
• Extractor for contexts using Page Render

sortable-behavior-bundle doesn't support multiple entity managers out of the box

When using sortable-behavior-bundle package with Sonata Admin as described by
8. Sortable behavior in admin listing in a project with several entity managers, the following error appear:

An exception has been thrown during the rendering of a template ("The class 'App\ModuleB\Entity\ValueName' was not found in the chain configured namespaces App\ModuleA\Entity").

This error is raised by vendor/runroom-packages/sortable-behavior-bundle/src/Resources/views/sort.html.twig line 2 : {% set current_position = currentObjectPosition(object) %}

The app use a modular monolith architecture with one database per module. The issue lies with the ORMPositionHandler and GedmoPositionHandler services. They use EntityManagerInterface, that is auto-wired with the first of default entity manager.

It should auto-wire the Doctrine ManagerRegistry to get the correct EntityManager for the class using the getManagerForClass method.

Or the documentation should provide an example on how to create a custom Position Handler service for each entity manager.

Thank you for your work.

Move from annotation to xml files for doctrine schema definition.

[Sortable] `.disableSelection()` is deprecated

On my version of jquery-ui (I'm using v1.13.2) it doesn't even exist and leads to an error, rendering the drag-and-drop unusable.

See https://api.jqueryui.com/disableselection/

[RunroomSeoBundle] Build metas without SeoModel

MetaInformation and AlternateLinks should be able te be built without needing a SeoViewModel.
There are pages that do not need model.

Runroom testing package 0.16

The package requires Runroom/testing:"^0.16", but no such version exists. That's why developer can't install dependencies
https://github.com/Runroom/runroom-packages/blob/master/packages/sortable-behavior-bundle/composer.json
Can you make 0.16 tag for Runroom/testing?

Modify service definitions

We need to define names for services declared on container.

Before:

    $services->set(BasicPageController::class)
        ->public()
        ->arg('$service', new ReferenceConfigurator(BasicPageService::class))
        ->call('setContainer', [new ReferenceConfigurator(ContainerInterface::class)])
        ->tag('container.service_subscriber')
        ->tag('controller.service_arguments');

After:

    $services->set('runroom.basic_page.controller.basic_page', BasicPageController::class)
        ->public()
        ->arg('$service', new ReferenceConfigurator(BasicPageService::class))
        ->call('setContainer', [new ReferenceConfigurator(ContainerInterface::class)])
        ->tag('container.service_subscriber')
        ->tag('controller.service_arguments');

Add translation files

We use some translations, currently located on symfony archetype. We should move them here on the corresponding bundles.