rupan/libatasmart

LIBATASMART ATA S.M.A.R.T. Reading and Parsing Library

libatasmart's Issues

Miscalculation of lbas read/written

libatasmart/atasmart.c

Line 1225 in de62589

a->pretty_value = fourtyeight * 65536LLU * 512LLU / 1000000LLU;

This line seems does lbas-read/written * 65536 * 512 (sectors) / 1000000 (mb). However on my various varieties of Samsung ssd this 65536 multiple is incorrect, it should actually just be * 512 / 1000000 to get mb. This means I'm having to put a *16 factor in to convert to bytes/sec

Documentation error for libatasmart

I'm trying to understand the output of skdump as I noticed: Attribute Parsing Verification: Bad in the output on my new drive;

however: man skdump, man libatasmart do not yield any result, on the main site: http://0pointer.de/blog/projects/being-smart.html the two links to the README/API throw an error: Invalid request
http://git.0pointer.net/?p=libatasmart.git;a=blob;f=atasmart.h
http://git.0pointer.net/?p=libatasmart.git;a=blob;f=README

can you please fix the documentation? (or, selfishly, can you please just share what that output means?)

Thank you.

Not Reading SATA disks

as gnome-disk-utility seems to be using libatasmart

how can I go about getting it to reading all disks as SATA ?

I have to use "smartctl -d sat" to read smart on my disks just wondering what kind of changes I could make to libatasmart to make it work , drives are on a HBA Controller

skdump does not correctly recognize external hard drives

External hard drives appear to be not supported:

sudo skdump /dev/sdb

Device: sat12:/dev/sdb
Type: 12 Byte SCSI ATA SAT Passthru
Size: 9537504 MiB
Awake: Operation not supported
ATA SMART not supported.

despite being SMART capable:

$ sudo smartctl --info /dev/sdb

smartctl 7.1 2019-12-30 r5022 [x86_64-linux-5.4.0-65-generic] (local build)
...
SMART support is: Available - device has SMART capability.
SMART support is: Enabled

The reason for this errorful assumption of skdump is probably that external hard drives do not support the Awake operation, since spinning up and down is entirely handled by the chip within the external case itself.

GNU GPL v2.0 License violation

According to this you must use GPL v2.0, not LGPL

Outdated config.guess file in the release tarball

Currently the config.guess file in the tarball is too old to properly detect RISC-V platform. It can be updated by executing autoreconf -fiv.

Missing header dependency

https://github.com/Rupan/libatasmart/blob/master/atasmart.h is missing dependency on stddef.h (for size_t which is not provided by inttypes.h).

Possibly bad temperature reporting

I am running cockpit and found that my SSD reported an 86ºC temperature which I hope it is not correct. I was wondering if this could be an issue with cockpit and found that the project gets it's data from this library.

When performing an skdump I get two celsius temperatures one is 23ºC which seems more reasonable to me and the other one is reported as 86ºC. I was wondering if this may be an error or if it really can be....

What can I do for debugging?

Thank you!

% sudo skdump /dev/sda
Device: sat16:/dev/sda
Type: 16 Byte SCSI ATA SAT Passthru
Size: 228935 MiB
Model: [KINGSTON SA400S37240G]
Serial: [50026B768327A9FE]
Firmware: [SBFKB1D1]
SMART Available: yes
Quirks:
Awake: yes
SMART Disk Health Good: yes
Off-line Data Collection Status: [Off-line data collection activity was never started.]
Total Time To Complete Off-Line Data Collection: 65535 s
Self-Test Execution Status: [The previous self-test routine completed without error or no self-test has ever been run.]
Percent Self-Test Remaining: 0%
Conveyance Self-Test Available: yes
Short/Extended Self-Test Available: yes
Start Self-Test Available: yes
Abort Self-Test Available: yes
Short Self-Test Polling Time: 2 min
Extended Self-Test Polling Time: 30 min
Conveyance Self-Test Polling Time: 6 min
Bad Sectors: No such file or directory
Powered On: 1.5 years
Power Cycles: 99
Average Powered On Per Power Cycle: 5.6 days
Temperature: 86.0 C
Attribute Parsing Verification: Good
Overall Status: GOOD
ID# Name                        Value Worst Thres Pretty      Raw            Type    Updates Good Good/Past
  1 raw-read-error-rate         n/a   100     0   0           0x000000000000 old-age online  n/a  n/a
  9 power-on-hours              100   100     0   1.5 years   0x013400000000 old-age online  n/a  n/a
 12 power-cycle-count           100   100     0   99          0x630000000000 old-age online  n/a  n/a
148 attribute-148               100   100     0   n/a         0x000000000000 old-age offline n/a  n/a
149 attribute-149               100   100     0   n/a         0x000000000000 old-age offline n/a  n/a
167 attribute-167               100   100     0   n/a         0x000000000000 old-age offline n/a  n/a
168 attribute-168               100   100     0   n/a         0x000000000000 old-age online  n/a  n/a
169 attribute-169               100   100     0   n/a         0x0d0000000000 old-age offline n/a  n/a
170 available-reserved-space    100   100    10   100%        0x090000000000 old-age offline yes  yes
172 erase-fail-count            100   100     0   0           0x000000000000 old-age online  n/a  n/a
173 attribute-173               100   100     0   n/a         0xc40088000000 old-age offline n/a  n/a
181 program-fail-count-total    100   100     0   0           0x000000000000 old-age online  n/a  n/a
182 erase-fail-count-total      100   100     0   0           0x000000000000 old-age offline n/a  n/a
187 reported-uncorrect          100   100     0   0 sectors   0x000000000000 old-age online  n/a  n/a
192 power-off-retract-count     100   100     0   82          0x520000000000 old-age online  n/a  n/a
194 temperature-celsius-2        77    47     0   23.0 C      0x170012003500 old-age online  n/a  n/a
196 reallocated-event-count     100   100     0   0           0x000000000000 old-age online  n/a  n/a
199 udma-crc-error-count        100   100     0   0           0x000000000000 old-age online  n/a  n/a
218 attribute-218               100   100     0   n/a         0x210700000000 old-age online  n/a  n/a
231 temperature-celsius          14    14     0   86.0 C      0x560000000000 old-age offline n/a  n/a
233 power-on-seconds-2          100   100     0   n/a         0x117f00000000 old-age online  n/a  n/a
241 total-lbas-written          100   100     0   535.864 GB  0x623e00000000 old-age online  n/a  n/a
242 total-lbas-read             100   100     0   2.882 TB    0x784f01000000 old-age online  n/a  n/a
244 attribute-244               100   100     0   n/a         0x880000000000 old-age offline n/a  n/a
245 attribute-245               100   100     0   n/a         0xc40000000000 old-age offline n/a  n/a
246 attribute-246               100   100     0   n/a         0xa0fa0f000000 old-age offline n/a  n/a

Please add JSON output in skdump

Also, see https://tracker.ceph.com/issues/39365