Giter Site home page Giter Site logo

Comments (2)

rurban avatar rurban commented on July 30, 2024 2

I think you are right with clearing dest on dmax > MAX. I changed that in strncat_s, wcsncat_s with 19d4914 but we do it with slen > MAX. I reverted that in d0e31c8. I matches msvcrt better now.

For the whole slen=0 scenario we'll be much more forgiving and do the HAVE_C11 logic. But interestingly on some cases dest is cleared, on some not. Still have to evaluate where, why and how.

from safeclib.

Juno-Explorer avatar Juno-Explorer commented on July 30, 2024

I think handle_error for dmax > RSIZE_MAX is not needed.

A/c to standard,
If there is a runtime-constraint violation, then if s1 is not a null pointer and s1max is greater than zero and not greater than RSIZE_MAX, then strncpy_s sets s1[0] to the null character.

It clearly states that to set dest[0] = ‘\0’ dmax should be greater than 0 and less than RSIZE_MAX. So using handle_error for dmax > RSIZE_MAX is deviation from C11 Standard.

Moreover for slen = 0 standard doesn’t claim that it’s an error scenario (which I have already stated in issue#31) and other compilers which support C11 i.e IAR ARM and MSC doesn’t update destination at all when slen = 0.

I think your changes to cater this issue would make your implementation to deviate from C11 standard.

from safeclib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.