Comments (2)
I think you are right with clearing dest on dmax > MAX. I changed that in strncat_s, wcsncat_s with 19d4914 but we do it with slen > MAX. I reverted that in d0e31c8. I matches msvcrt better now.
For the whole slen=0 scenario we'll be much more forgiving and do the HAVE_C11 logic. But interestingly on some cases dest is cleared, on some not. Still have to evaluate where, why and how.
from safeclib.
I think handle_error for dmax > RSIZE_MAX is not needed.
A/c to standard,
If there is a runtime-constraint violation, then if s1 is not a null pointer and s1max is greater than zero and not greater than RSIZE_MAX, then strncpy_s sets s1[0] to the null character.
It clearly states that to set dest[0] = ‘\0’ dmax should be greater than 0 and less than RSIZE_MAX. So using handle_error for dmax > RSIZE_MAX is deviation from C11 Standard.
Moreover for slen = 0 standard doesn’t claim that it’s an error scenario (which I have already stated in issue#31) and other compilers which support C11 i.e IAR ARM and MSC doesn’t update destination at all when slen = 0.
I think your changes to cater this issue would make your implementation to deviate from C11 standard.
from safeclib.
Related Issues (20)
- Arm64 compilation has incorrect assembly instructions HOT 3
- fix Cirrus CI HOT 1
- `getenv_s` calls error handler for "normal" errors HOT 3
- fix new mingw64 tmpfile_s error
- Setting sl_default_handler to abort_handler_s before runtime HOT 4
- fprintf_s printing NULL characters to file HOT 2
- check strpbrk_s for slen overflow or early exit with small slen
- s,handle_str_bos_overload,handle_str_bos_overflow,
- add n2809: thrd_set_constraint_handler_s HOT 1
- getenv_s problems with NULL terminator? HOT 3
- dont set errno = 0 HOT 1
- It's "`NUL` terminated"..... HOT 3
- Using safeclib with vxWorks HOT 1
- Is it "safe" to have large values of RSIZE_MAX_MEM? HOT 2
- Compiling on Apple M1/M2/M3 HOT 2
- Release 3.8.0? HOT 1
- Build issue on RHEL 8.6 HOT 1
- Implicit declaration of fileno in vfprintf_s.c HOT 4
- CMake support? HOT 1
- Non-portable format strings HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from safeclib.