rust-osdev/ovmf-prebuilt

ovmf-prebuilt's Issues

Compile error[E0658]: use of unstable library feature 'restricted_std'

When compiling for the target x86_64-unknown-none I get the error message:

error[E0658]: use of unstable library feature 'restricted_std'
  |
  = help: add `#![feature(restricted_std)]` to the crate attributes to enable

I added the attribute #![feature(restricted_std)] to the top of the lib.rs file and also had to add it to my project main.rs file which corrected the issue. The change also successfully compiled for the x86_64-pc-windows-msvc target. This occurs for the nightly-x86_64-pc-windows-msvc toolchain, but the attribute can't be applied for the 'stable' or 'beta' compilers: https://doc.rust-lang.org/error_codes/E0554.html

This is my first issue and I am not sure what the standard procedure would be for getting this fixed. Is there a way to add attributes for specific toolchains, or is that not recommended because the feature "may be removed or altered in the future"? Any input would be greatly appreciated.

Note: Edited as I found that the feature attribute does not compile for stable/beta channel.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Awaiting Schedule

These updates are awaiting their schedule. Click on a checkbox to get an update now.

• chore(deps): lock file maintenance

Detected dependencies

cargo

build-edk2/Cargo.toml

• anyhow 1.0.0
• clap 4.0.0

dockerfile

build-edk2/Dockerfile

github-actions

.github/workflows/build_tag.yml

• actions/checkout v4

.github/workflows/ci.yml

• actions/checkout v4
• Swatinem/rust-cache v2

---

• Check this box to trigger a request for Renovate to run again on this repository

Add a library crate to the repo for downloading/caching prebuilts

As mentioned in #37 (comment), I'd like to add a library crate here, essentially an upgrade to https://crates.io/crates/ovmf-prebuilt to make it easy to get the new prebuilts.

Filing an issue here to lay out a quick plan:

1. Make the repo a workspace so we can have multiple packages. Initially this will just be one package, build-edk2, containing the code that's currently in src/. build-edk2 will not be published.
2. Add an ovmf-prebuilt package to the workspace. This can start at version 0.2.0 to supersede the currently-published versions.
3. Implement functionality in ovmf-prebuilt similar to what we have in uefi-rs: https://github.com/rust-osdev/uefi-rs/blob/ccdfb66cd073442e3dc08412a7c18369d906aff7/xtask/src/qemu.rs#L95. This differs from the previous approach of putting the binaries directly in the crates.io release. I couldn't find any specific policy about uploading prebuilts on crates.io, but this discussion makes it sound at least discouraged.