Giter Site home page Giter Site logo

Fix failing unit tests about rustpython HOT 7 CLOSED

dchiquito avatar dchiquito commented on May 27, 2024 1
Fix failing unit tests

from rustpython.

Comments (7)

dchiquito avatar dchiquito commented on May 27, 2024

The test_import and test_importlib bugs should be fixed by #5192

from rustpython.

dchiquito avatar dchiquito commented on May 27, 2024

The test_with bugs should be fixed by #5203

from rustpython.

dchiquito avatar dchiquito commented on May 27, 2024

The test_typing errors are caused by this test in test_typing.py:

class ProtocolTests(BaseTestCase):
    ...
    def test_protocols_bad_subscripts(self):
        T = TypeVar('T')
        S = TypeVar('S')
        with self.assertRaises(TypeError):
            class P(Protocol[T, T]): pass
        with self.assertRaises(TypeError):
            class P(Protocol[int]): pass
        with self.assertRaises(TypeError):
            class P(Protocol[T], Protocol[S]): pass
        with self.assertRaises(TypeError):
            class P(typing.Mapping[T, S], Protocol[T]): pass # <- specifically this line

This specific line is corrupting the typing.Mapping object in some way that renders the unittest.mock module unimportable. I suspect that the line in question Protocol.__init_subclass__ sets __subclasshook__ before it fails, which is then called somehow in unittest.mock.

from rustpython.

dchiquito avatar dchiquito commented on May 27, 2024

The test_mmap/test_os failures should be resolved by #5204

from rustpython.

dchiquito avatar dchiquito commented on May 27, 2024

The test_typing errors should be resolved by #5207

from rustpython.

dchiquito avatar dchiquito commented on May 27, 2024

Everything seems to have been resolved.

from rustpython.

youknowone avatar youknowone commented on May 27, 2024

Thank you so much! This series is really helpful 😄

from rustpython.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.