rustyrussell/bolt12address

BOLT12 Lightning Address Format

bolt12address's Issues

lightingaddress.com sells Arab lamps?

Maybe you meant a different URL in the README?

Python check fails

I created a thing using the Python incantation in #1 (master branch commit c4c55b7)

https://sprovoost.nl/.well-known/bolt12/bitcoin/[email protected]

But the verification fails:

./bolt12address.py check --raw-stdin < /var/www/well-known/bolt12/bitcoin/[email protected] 
Traceback (most recent call last):
  File "/home/sjimmie/src/bolt12address/python/./bolt12address.py", line 339, in <module>
    args.func(args)
  File "/home/sjimmie/src/bolt12address/python/./bolt12address.py", line 189, in check
    ap = AddressProof(sys.stdin.buffer.read())
  File "/home/sjimmie/src/bolt12address/python/./bolt12address.py", line 21, in __init__
    super().__init__("lnap", generated.tlv_addressproof, proof)
  File "/home/sjimmie/.pyenv/versions/3.9.6/lib/python3.9/site-packages/bolt12/bolt12.py", line 293, in __init__
    self.values, self.unknowns = helper_fromwire_tlv(tlv_table, bytestr)
  File "/home/sjimmie/.pyenv/versions/3.9.6/lib/python3.9/site-packages/bolt12/bolt12.py", line 56, in helper_fromwire_tlv
    raise ValueError('Invalid: Unknown even field number {}'.format(tlv_type))
ValueError: Invalid: Unknown even field number 108

lightning-cli decode thinks the whole string Is broken: string: Bad bech32 string: invalid token '\"lnap1...5kj6zs\"'"

Certificate expiration and privacy

The README mentions:

But you don't need to reach out to blockstream.com: anyone (including your wallet vendor, or the node claiming to be blockstream.com) can collect all the addressproofs and certificates for you, as they contain a signature using the existing web certificate infrastructure. Bundling these protects your privacy more than having to request to a vendor's website before making a payment.

Websites that use a free service like LetsEncrypt tend to have short expiration, which means in the above example either:

1. the wallet (vendor) has to fetch a new certificate regularly
2. we tolerate expired https certificates

I don't know if (2) is worth the extra privacy gain, because it adds complexity to implementations.

Certbot renewal hook hints

It would be useful to provide instructions for common setups, e.g. a certificate generated by certbot that's renewed every X months. I believe you can give it script to call after renewal, that would update the record.

Cryptic Python create failure at AddressProof step

Using the following (with NODE_ID replaced with my node id):

./bolt12address.py create [email protected] /.../privkey.pem /.../cert.pem /.../chain.pem NODE_ID  --description "Open source development donation" --chain bitcoin

The following cryptic error is thrown:

Traceback (most recent call last):
  File "/home/sjimmie/src/bolt12address/python/./bolt12address.py", line 262, in <module>
    args.func(args)
  File "/home/sjimmie/src/bolt12address/python/./bolt12address.py", line 168, in create
    ap = AddressProof.create(args.vendor,
  File "/home/sjimmie/src/bolt12address/python/./bolt12address.py", line 31, in create
    self = cls(None)
  File "/home/sjimmie/src/bolt12address/python/./bolt12address.py", line 19, in __init__
    super().__init__("lnap", generated.tlv_addressproof, proof)
  File "/home/sjimmie/.pyenv/versions/3.9.6/lib/python3.9/site-packages/bolt12/bolt12.py", line 289, in __init__
    self.values, self.unknowns = helper_fromwire_tlv(tlv_table, bytestr)
  File "/home/sjimmie/.pyenv/versions/3.9.6/lib/python3.9/site-packages/bolt12/bolt12.py", line 37, in helper_fromwire_tlv
    while len(buffer) != 0:
TypeError: object of type 'NoneType' has no len()

I guess it's missing something, but it's not clear what.