should luerl_new:load convert error atom to lua_error?

[samaaron]

should luerl_new:load convert error atom to lua_error?

[rvirding]

Hi @samaaron which version of Luerl are you using? Could you give me an example of when this happens?

[samaaron]

Hi @rvirding,

I'm using version 1 from Elixir:

"luerl": {:hex, :luerl, "1.0.0", "1b68c30649323590d5339b967b419260500ffe520cd3abc1987482a82d3b5a6c", [:rebar3], [], "hexpm", "c17bc45cb4b0845ec975387f9a5d8c81ab60456698527a29c96f78992af86bd1"},

This was pulled in via Elixir's mix after declaring the following dep: {:luerl, "~> 1.0"}

The error tuple containing the error atom is the result of a syntax error and can be replicated with:

:luerl_new.do_dec("dfdf333" lua_state)

It returns:

{:error, error, state}

[samaaron]

Ah, looks like v1.0 is rather old. I was looking at the source provided in the deps folder pulled down from hex to see what was happening rather than looking at the develop branch on Github.

Seems that the latest code does what the documentation describes:

https://github.com/rvirding/luerl/blob/develop/src/luerl_new.erl#L226

Is there anything holding back from getting a new release tagged?

[samaaron]

Actually after playing around, both the latest development version and v1.0 appear to behave similarly here:

iex(2)>  :luerl_new.do_dec("3434ddd", l)
{:error, [{1, :luerl_parse, [~c"syntax error before: ", [~c"3434"]]}], []}

[rvirding]

The reason for this is that lua_error is returned when running Lua code. The compiler in this sense does not really return a Lua error hence the error. When running say loadfile from within Lua then the compiler error is caught, all erros actually, and a string describing the error is returned.