Giter Site home page Giter Site logo

Comments (7)

rvirding avatar rvirding commented on July 28, 2024

The trouble is that the value of the of the arguments can be any valid Lua data type. Try:

result, error = pcall(function()     
  ipairs(dofile)
end)

return result, error

from luerl.

markmeeus avatar markmeeus commented on July 28, 2024

Ah yes, I see, the format throws argument errors when the format param is not compatible.
I think I was expecting an elixir 'inspect' type of formatting there.

So to fix this we would need format_argument type of functions for every possible argument type that goes into the io_lib:format. These would then format the structure to a string, (maybe with a default implementation using a plain ~w)
And then use the string format?

So that the format_error would look like this:

format_error({badarg,Where,As}) ->
    io_lib:format("badarg in ~s: ~s", [format_where(Where), format_args(As)]);

from luerl.

rvirding avatar rvirding commented on July 28, 2024

You have discovered another bug which needs fixing first. 😄 The ipairs function never checks its argument and always succeeds, it is the function which it returns which checks that its argument is a table.

I will fix that first and then we can get back to the error message from pcall. I have some ideas about that.

from luerl.

rvirding avatar rvirding commented on July 28, 2024

The ipairs and pairs handling of arguments has now been fixed.

from luerl.

rvirding avatar rvirding commented on July 28, 2024

One thing is that the current get_stacktrace function is really designed to build a "better" current stack and not really print it out. That could be another function.

from luerl.

markmeeus avatar markmeeus commented on July 28, 2024

The thing is that this formatting happens in the pcall, so these binaries are returned to the lua code. These users may not be familiar to these erlang binary format .

from luerl.

rvirding avatar rvirding commented on July 28, 2024

This has now been fixed a commit in the develop branch dd78ff5

from luerl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.