(Mod conflict) General Multiplayer patches can fail on generic types

[SokyranTheDragon]

(Mod conflict) General Multiplayer patches can fail on generic types

[SokyranTheDragon]

I think I may have an idea on how to handle this... I'll try to get something up soon. Hopefully my attempts will end better than 2 years ago when I tried and gave up with no idea on how to do it.

[SokyranTheDragon]

The solution I thought of won't work due to issues with Harmony and generics. The Harmony documentation made me believe it would work, which was not the case.

I suppose the simplest fix for startup errors would be to skip patching generics (and leaving an appropriate warning/error?)... Which for obvious reason is not a good solution, but would at least stop everything from breaking fully on startup.

At least unless Prepatcher is capable of handling generics better than Harmony, or Zetrith has some way to handle it which will work. I myself am out of ideas here.

[Zetrith]

The SpawnSetup patch was missing a try/catch so I fixed it. This should do for now

[SokyranTheDragon]

Still need to change 2 places to use try/catch, as they could technically cause the same issues. Not a big issue at the moment.
https://github.com/rwmt/Multiplayer/blob/7429f3a8870a8696e5829de31a831c8d0f16ce4b/Source/Client/Syncing/Game/SyncMethods.cs#L64-L82
https://github.com/rwmt/Multiplayer/blob/7429f3a8870a8696e5829de31a831c8d0f16ce4b/Source/Client/Syncing/Game/SyncActions.cs#L17-L21

Still, this doesn't really fix the issue, as it'll just display a big red X next to the Multiplayer button (with an irrelevant message). This could technically be worked around by the mod itself calling the MP prefix and postfix/finalizer, but again - we'll be left with errors and the X informing people that Multiplayer errored out. Sadly, for the time being - this basically means that some mods (like Project Rimfactory) will remain incompatible with MP and no easy fix...