rxi/lite

A lightweight text editor written in Lua

lite's Issues

Create new file, when invoked with non-existing file as an argument

When you invoke it from terminal like: lite new_file.txt it should create new document and upon saving create new file with the specified name. Currently it just opens 'empty' window.

Crash on launch on OSX

Compilation was easy enough for me too.
When launching from terminal everything works.
If I just launch through finder I'm getting a crash after 2 secs:

gianmichelemariani$ /Users/gianmichelemariani/Projects/lite/lite ; exit;
Error: /Users/gianmichelemariani/Projects/lite/data/core/init.lua:397: /Users/gianmichelemariani/Projects/lite/data/core/init.lua:369: /Users/gianmichelemariani/Projects/lite/data/core/init.lua:30: could not open directory: ./Library/Application Support/CallHistoryDB
stack traceback:
[C]: in function 'run_threads'
/Users/gianmichelemariani/Projects/lite/data/core/init.lua:397: in function 'run'
[string "local core..."]:10: in function <[string "local core..."]:2>
[C]: in function 'xpcall'
[string "local core..."]:2: in main chunk
logout
Saving session...
...copying shared history...
...saving history...truncating history files...
...completed.
Deleting expired sessions...none found.

For some reason I remember it asking for contacts access at some point.

OSX 10.14.6 Macbook pro 13"

Happy New Year :D

Lite not starting when executed from command-line outside of its own directory (Ubuntu 19.10)

I use Ubuntu 19.10, Linux 5.3.0-24-generic

After cloning and building Lite without any problem, I moved its directory to my /opt/. I created a symlink to the binary in my /usr/sbin/ to use Lite globally. But once launched in any directory that is not its own (in my case /opt/lite/), it prints out this error and exits:

Error: [string "local core..."]:7: attempt to concatenate global '_EXEDIR' (a nil value)
stack traceback:
	[string "local core..."]:7: in function <[string "local core..."]:2>
	[C]: in function 'xpcall'
	[string "local core..."]:2: in main chunk

I fixed it by adding my own path to the Lua string in src/main.c, line 66, as follows:

_EXEDIR = _ARGS[1]:match('(.*)[/\\\\].*$') or '/opt/lite'

After recompiling, it launched perfectly fine.
But of course this edit only works for me.

As I understand it, you need to access the data/ directory where the Lua scripts are located. Why not have an installation script that saves into a user config file where the sources are?
Also, I guess I need to write in data/user/init.lua if I want to customize Lite's behavior, but what about having a .literc file or .lite directory in the user's home?

Thank you for your time and work on this project :)

Screen is not always redrawn when window is resized.

Seen on Windows on version 1.03

When dragging the window so that it snaps between being maximised and smaller, the screen will sometimes not redraw when the window becomes maximised again.

Repro steps:

• Ensure window is maximised
• Click and drag the title bar so that the window becomes smaller
• Drag the window around a bit (Ensure left mouse button is held down)
• Drag the title bar back to the top of the screen and release the mouse button.
• The window should auto-snap back to maximised size and the screen will not redraw properly.

This only works if the mouse button is held down throughout. If you release it when the window is smaller, everything works just fine. Let me know if you need any more info :) I'm loving the editor so far btw!

Paste duplication

Steps to reproduce:

1. Cut text via Ctrl-X
2. Paste via Ctrl-V
3. The text is pasted twice

it looks fantastic

Error building on Ubuntu Mint (Linux) v 20.04

Here is my output from running the build command. As somebody not familiar with Linux or C it appears I am missing a dependency named SDL2, but I don't know what that is. I attempted to run: sudo apt-get install SDL2 but the package does not exist.

austin@austin-VirtualBox1:~/lite$ ./build.sh
compiling (unix)...
In file included from src/renderer.c:5:
src/renderer.h:4:10: fatal error: SDL2/SDL.h: No such file or directory
    4 | #include <SDL2/SDL.h>
      |          ^~~~~~~~~~~~
compilation terminated.
In file included from src/rencache.h:5,
                 from src/rencache.c:2:
src/renderer.h:4:10: fatal error: SDL2/SDL.h: No such file or directory
    4 | #include <SDL2/SDL.h>
      |          ^~~~~~~~~~~~
compilation terminated.
src/main.c:2:10: fatal error: SDL2/SDL.h: No such file or directory
    2 | #include <SDL2/SDL.h>
      |          ^~~~~~~~~~~~
compilation terminated.
In file included from src/api/renderer.c:2:
src/renderer.h:4:10: fatal error: SDL2/SDL.h: No such file or directory
    4 | #include <SDL2/SDL.h>
      |          ^~~~~~~~~~~~
compilation terminated.
src/api/system.c:1:10: fatal error: SDL2/SDL.h: No such file or directory
    1 | #include <SDL2/SDL.h>
      |          ^~~~~~~~~~~~
compilation terminated.
In file included from src/api/renderer_font.c:2:
src/renderer.h:4:10: fatal error: SDL2/SDL.h: No such file or directory
    4 | #include <SDL2/SDL.h>
      |          ^~~~~~~~~~~~
compilation terminated.
cleaning up...
done

Capslock mapped to Control doesn't map to Control inside lite (Manjrao/KDE Plasma)

Hello,
I found this quite curious - no shortcuts (eg C-f) were working until I tried the real Control key and suddenly the editor made sense ;)

There are no other GUI applications where this happens. Any tips on how to fix it?
After 20 years its really hard to not use Caps-As-Control...

keymap: use command instead of control on macOS

Hi there - awesome project!

On macOS, the command key is generally the default modifier instead of control. I'd be happy to work on this with a little guidance as I'm not too familiar with Lua. I'm not sure if there's a way to detect if we're on mac at compile time or if runtime checks will be necessary.

Few small quirks using Windows 10

Hi

I am really enjoying exploring Lite (Windows 10 - on a small screen laptop). The speed and beauty are very attractive, but there are a few minor points that detract from my pleasure.

1. Rendering long lines

I respect the decision against proper word wrapping, but the current situation is not "nice". As I type near the right window margin the whole screen scrolls, with no horizontal scroll bar - this is very disorientating.

When the screen is in this scrolled state I cannot accurately select a position with the mouse - the text jumps left/right - a single click selects several characters.

2. core.command_view:enter leaves pixels on the last row of the screen

On first opening there is a very clean window. After each use of command entry / find / eval / exec - I can see pixels on the last row of the screen - matching those from the top row of the single line command window which has been closed (?off by one). These stray pixels are unaffected by window scrolling or resizing.

3. Log view won't scroll to the right

If I mess up and Lua issues a long error message I can't see the text beyond the right screen edge. The End and Right keys don't function, and there is no horizontal scroll bar.

4. Eval text entry not syntax highlighted

I would be really nice to have Lua syntax highlighting when typing in the eval plugin.

5. Output Window

When using the eval plugin (windows 10) any print statements produce no output. The return value inserts as expected. Is there any way to capture stdout and append to a buffer? I would prefer a solution with output in a fully editable buffer - not a limited buffer like "Log".

6. Loading binary libraries

I note that package.cpath is set (e.g. P:\MyPrograms\EDITORS\LiteMOD?.dll;P:\MyPrograms\EDITORS\LiteMOD\loadall.dll;.?.dll) but I can't get any of my Lua52 binary libraries to load. I understand some may be dependent upon lua52.dll but I can't get anything to load. (Any examples that work would be interesting - so I can see what was used to compile them)

Many thanks for the latest release, especially for eval which allows me to prod and poke.

Kind Regards Gavin Holt

I am using the latest release, and the _SCALE variable in my init.lua to make things bigger.

Extremely small on HiDPI screens

The title explains it. My real dpi is 144, it seems to use 96 dpi.

Can be fixed by modifying main.c (return 1.0 -> return 1.4)

Why not SDL_ttf ?

Maybe it could be better to use SDL_ttf. I know that it doesn't change anything totally, but it could make code more consistent and better for packaging i guess.

Editor hotkeys found so far

The following information might be the product of multiple plugins used from https://github.com/rxi/lite-plugins.

The test took place under an ANSI C demo code.

So far I have detected the following hotkeys, in case you are interested:

• Ctrl+L highlights the whole line
• Ctrl+\ hides the sidebar
• Ctrl+D highlights the word under cursor and shows with highlighted border around multiple findings of that word
• Ctrl+P it opens a file from a project
• Ctrl+Shift+P runs a command
• Ctrl+Shift-D duplicates a line
• Ctrl+Shift+K deletes line under cursor
• Shift+RightArrow highlights character by character and behaves much like Ctrl-D
• Ctrl+O Opens a file
• Ctrl+F Find Text (in current opened file)
• Ctrl+Shift+F Find text in entire Project
• Ctrl+R Finds something and replaces it
• Ctrl+J This is a very interesting command: it deletes the newline from the end of a line; in other words, you have 3 lines, you place your cursor anywhere in your first line and press the hotkey twice. Now you have a single line.
• Ctrl+G Go to line
• Ctrl+S Save file
• Ctrl+Shift+S Save as
• Ctrl+A Select all text
• Ctrl+[ and Ctrl+] jumps from code block to code block? 🤷
• Ctrl+Shift+[ and Ctrl+Shift+] highlights 3-ish lines forward and backward, respectively
• Ctrl+' Converts all your text to a single, minified line with escaped characters and newlines
• Ctrl+/ comments the current line; to select multiple lines, press Ctrl+Shift and your arrows to select the lines you want, then the aforementioned command.
• Ctrl+Arrows Moves the line up or down
• Ctrl+Shift+Q it adds a number sign, a hashtag, a pound sign..?, name it however you like, and makes a code block as a single line; weird behavior
• Alt+Shift+L clones the current screen on your right, vertically while maintaining curret's position on the cloned file; press Ctrl+W to close it
• Alt+Shift+K clones the current screen on the bottom, horizontally while maintaining curret's position on the cloned file; press Ctrl+W to close it
• Alt+Shift+J clones the current screen on your right, vertically while maintaining curret's position on the opened file; press Ctrl+W to close it

Crash on startup without arguments

First off: this is AMAZING! Thank you so much for creating lite, it feels just like home coming from Atom :)

When I open lite passing a path as first argument i.e. lite ~/projects/ it works just fine. However opening lite without a path crashes on my system due to lite scanning my whole $HOME and stumbling upon some Proton file.

~> lite
Error: /home/mirodin/bin/liteeditor/data/core/init.lua:397: /home/mirodin/bin/liteeditor/data/core/init.lua:369: /home/mirodin/bin/liteeditor/data/core/init.lua:30: could not open directory: ./games/SteamLibrary/steamapps/common/Proton 3.16 Beta/dist/share/default_pfx/dosdevices/z:/etc/cups/ssl
stack traceback:
	[C]: in function 'run_threads'
	/home/mirodin/bin/liteeditor/data/core/init.lua:397: in function 'run'
	[string "local core..."]:9: in function <[string "local core..."]:2>
	[C]: in function 'xpcall'
	[string "local core..."]:2: in main chunk

Using a non-custom build system for lite

Hello,

this has already been mentioned in #45 (comment), but I think a non-custom build system like meson would greatly benefit lite, making it easier to build on more platforms. I could look into doing that while I package it for Alpine Linux.

Customize scrollbar width

The scrollbar is too narrow. It requires too much precision when trying to scroll a split because the cursor sometimes becomes the adjustment pointer.

Example: in a left-right window split. Trying to scroll in the left window.

Sent from my HUAWEI GR5 2017 using FastHub

Problems with Notebook's keys

Home, End, PgUp, PgDn, etc. and their combinations with mod keys dosn't works for me.
I added core.log_quiet("Key pressed %s", k) to keymap.on_key_pressed function and got results:
Home -> keypad 7
End -> keypad 1
PgUp -> keypad 9
PgDn -> keypad 3
and similar results for arrows.

Are there users with the same problems?

Double/triple click persists after moving mouse

Looks like some SDL thing. If you click twice in 2 different locations in quick succession, it selects a word. If you do it three times it selects the line. The click count should reset when clicking somewhere else in a different location.

Additionally, it looks like SDL's clicks goes beyond 3, which means that if you click more than 3 times, nothing happens, which is inconsistent with the rest of the system.

This is on Linux.

Cyrillic fonts/names of files. Tree view

Cyrillic names of files don't displayed correctly in tree view.
I use the same font for tree and for code view.

attempt to concatenate global '_EXEDIR' (a nil value)

I downloaded the lite.zip from the releases page, unzipped it into a .lite directory into my user folder and ran the executable from this folder just to check out if it opened without crashing or something.

Then, I decided to add this folder to my PATH, it runs but instantly crashes with the message: attempt to concatenate global '_EXEDIR' (a nil value):

Tree view is not resizable.

The mouse cursor changes when you hover over the edge of the Tree-view area, but nothing happens when you drag it. Dragging to resize split editor panels works just fine.

Allowing data and the lite binary to reside in different directories

Hello,

right now lite assumes that the lite binary will be right next to the data directory - but that might not hold true in practice. E.g. linux distros would generally prefer having lite in /usr/bin while having the data in /usr/share/lite. It'd be nice if lite had a toggle to set that during build time - that could go hand-in-hand with #48 , e.g. by adding a "@datadir@" directive that's then replaced during compiletime instead of using the EXEDIR. I currently just patch around this for Alpine Linux.

Unable to build on Ubuntu:latest

I am trying to build this on ubuntu:latest.

Running ./build_release.sh file form the terminal produces a zip file that doesn't include the lite executable binary!!

Scrolling upward at the beginning of a file produces empty lines

Not sure it this is wanted behaviour, but scrolling upward (with the mouse wheel) when at the first line, produces infinite empty lines.

I'm on OSX 10.14.6

Segfault with SDL_VIDEODRIVER=wayland

Lite crashes with the wayland SDL driver when the window is closed (while it works fine with SDL_VIDEODRIVER=x11).

A gdb backtrace leads to malloc_consolidate:
0 0x00007ffff7b880ac in malloc_consolidate () from /usr/lib/libc.so.6
1 0x00007ffff7b89600 in _int_free () from /usr/lib/libc.so.6
2 0x00007ffff7e7bd6f in ?? () from /usr/lib/libSDL2-2.0.so.0
3 0x00007ffff7e5885a in ?? () from /usr/lib/libSDL2-2.0.so.0
4 0x00007ffff7e54a66 in ?? () from /usr/lib/libSDL2-2.0.so.0
5 0x00007ffff7eb8999 in ?? () from /usr/lib/libSDL2-2.0.so.0
6 0x00007ffff7ebcbbb in ?? () from /usr/lib/libSDL2-2.0.so.0
7 0x00007ffff7ebcf45 in ?? () from /usr/lib/libSDL2-2.0.so.0
8 0x00007ffff7e2a5cb in ?? () from /usr/lib/libSDL2-2.0.so.0
9 0x00007ffff7e2a6b8 in ?? () from /usr/lib/libSDL2-2.0.so.0
10 0x00007ffff7b3f537 in __run_exit_handlers () from /usr/lib/libc.so.6
11 0x00007ffff7b3f6ee in exit () from /usr/lib/libc.so.6
12 0x00005555555742f1 in os_exit (L=0x5555558382f0) at src/lib/lua52/loslib.c:295
13 0x000055555556a176 in luaD_precall (L=L@entry=0x5555558382f0, func=, func@entry=0x55555609c800, nresults=nresults@entry=0) at src/lib/lua52/ldo.c:319
14 0x0000555555580a77 in luaV_execute (L=L@entry=0x5555558382f0) at src/lib/lua52/lvm.c:709
... (abbreviated lua stack)

This is with Intel graphics on Manjaro.

can't open project folder out of lite root directory

OS Win 10 64bit
put lite in c:\lite and open c:\project dir from lite

how do you open a folder?

Hi, Cool project. I built it but I can't figure out how to open a folder. Ctrl-O only allows you to open files. What else should I try?

P.S. Where can I look to help me through these sorts of questions?

How to prevent directory loading when first run

Whenever I open Lite from run command on my XFCE4 system, it opens and immediately starts file loading procedure which makes no sense to me.

1. How do I prevent this?
2. How to open a directory of my choice, much like we do with Sublime Text and VSCode?

search result not scroll screen down by up down keys

results should be more than one screen

Syntax checks

It would be great if plugins could underline certain bits of code with a reason that's showed when the user hovers over them. This way we could implement syntax and code-style checks.

does not start from a directory called non-latin characters

OS Windows 10 64 bit
lite crash on start from a directory called non-latin characters
put lite exe to
c:\Проба
ant start lite

Toggle Statusview

Hi,

Would you consider implementing a Toggle Statusview command?

I'm working from home on a small laptop with old eyes, using the fantastic full screen mode I get 26 and one half lines, that means the status bar is taking about 4% of the available screen.

Also I would commend the aesthetics of full screen without status bar - it feels very pure :)

Kind Regards Gavin Holt

Allow plugins to be toggled on/off

Hello,

it'd be nice if it were possible to toggle plugins on/off during runtime instead of lite loading and enabling all available plugins

Clicking on a column at the far right of screen causes a selection box

I fixed it by making a change in docview.lua:

  -- scroll to make caret visible and reset blink timer if it moved
  local line, col = self.doc:get_selection()
  if (line ~= self.last_line or col ~= self.last_col) and self.size.x > 0 then
    if core.active_view == self and self.mouse_selecting == false then
      self:scroll_to_make_visible(line, col)

My change was adding and self.mouse_selecting == false

Ability to allow case insensitive keywords to language descriptions

see language_6502.lua I'd like to allow upper and lowercase keywords for this.

Add word wrap configuration

Would be nice to be able to have word wrapping.

While coding usually I don't make lines that long, but when writing text for articles and other things in html or markdown it's common to have longer lines. And in markdown an enter will have meaning.

Non-utf8 file support

Seems like lite currently supports only UTF-8 encoded files, files encoded in another codepages not displayed correctly and their editing is impossible.

Steps to reproduce that problem:

1. Create file encoded other than UTF-8 in any editor, or just print to file in windows console (IIRC output is saved in CP-037 codepage)
   I used Notepad++ to create file in windows-1251 codepage
   
   Here you can see that lite cannot display correctly that file and cannot properly edit them. This may be the reason why non-latin paths do not work in windows in #13

Files with long lines

The attached file hangs the editor for ~1 second on open.
If you rename the file to test.lua or test.js it crashes the editor instantly on open.

test.txt

Add a maximize command.

99% of the time I would like the program to start up with the window maximized. Yes, I can use operating system shortcuts to maximize it, but that's one extra thing I have to do every single time.

Fullscreen is nice (and it's easy to call in your user\init so it starts with it), but for everyday use I like to see my taskbar, so maximizing is better.

A user's feedback if I may

Hey @rxi,

I hope you are doing great.

This is an outstanding project, super light, super fast; kudos! 🥇

I have just downloaded the code, compiled it on my GNU / Debian testing 64-bit system, and my so far experience is the following:

• OK, how do I resize my sidebar?
• Where's the [x] button for the tab window? Meh...Ctrl+Shift+P lets me choose the command to close it; that's also an option.
• How do I scroll up or down my window using hotkeys? Ctrl+UpArrow/DownArrow do not work.
• Wait...why does it keep on running from inside the terminal? Should not it be like Sublime Text or VSCode that when you run it from inside a directory, it loads that directory and returns back to terminal? I really don't like adding an ampersand at the end of my executable: ./lite & 😒
• I have opened nearly all C and Lua files and consumes only 0.25% of CPU and 32 MiB of RAM...I mean...DUDE WHAT THE...! 🤯 , so the real question here is "how do I find out the number of opened tab windows?"; hmm...you can find the number of opened files by clicking Ctrl+Shift+P; not very convenient but it's better than nothing!
• What the hotkey for help command, if any?
• Menu bar?!
• README is not clear how to install a plugin or a theme; I guess I just copy and paste a file in data/plugins/ for plugins and data/user/colors/ for theme, respectively? 🤷
• What about right-click options?

That's it for now; I will continue with experimentation.

When this editor becomes stable enough, for sure I will switch to it for good; it's exactly what I was looking for!

Keep up the good work mate.

Cheers 👍

Compiling in macOS

Hi
thanks for the open source project,
I am trying to run it on my mac. I am able to compile it but when I run it, it opens as zoomed window

Can you help ?

Support for software text compositing

See https://wiki.libsdl.org/Tutorials/TextInput
Chinese and Japanese users (mostly) use IMEs (input method editors) to input characters, and these require some help from the applications to work properly. Thankfully, SDL exposes functionality to do this.

I have implemented some basic support for it here, the patch is not large (about 40 lines total).

Here's a demonstration of me inputting some text in Japanese without this patch (you can't see the characters as I type them and the candidate box shows up in the top left corner of the window):

and with the patch:

I changed the code font in those demos since the default one does not have glyphs for CJK characters.

The reason I'm making an issue for this is because it's requires adding stuff to the core (albeit it's not a lot) and it can technically be considered new functionality. It does not affect users who don't use an IME in any way. I haven't tested it on windows since I don't have a windows computer but I assume it would work since the SDL APIs that the patch uses are supposed to work there too.

I will also add that this is not an ideal implementation, as the compositing text shows up in a box hovering in front of the rest of the text (similar to an over the spot implementation), however in my opinion it's better to have at least some basic support than none at all.

Convergent Evolution?

Hi

I really like the Lite editor - really quick and really clean. Reminds me of TextAdept - an example of convergent evolution?

Should you choose to add functionality I think Textadept may offer a map to follow. The keyboard driven extension TextRedux is also worth a look.

I have been trying to mold the two together to produce a curses WIN32 editor looking much like Lite.

Some questions about the current version:

Q1. Is there a way to list all the available commands?

Q2. Can key bindings be associated with a specific mode?
I like ESC to core:quit - will this mess up the autocomplete script?

Q3. Is there a way to execute arbitrary Lua code - see my post on command line editing (sorry about the lack of CRLF in the post - still not sure how to set up gmail for this mailing list)

Q4. Documentation??

Kind Regards Gavin Holt

quick test of lite 1.03

first impression was good so I spent some time testing lite 1.03 on win10/hidpi

rendering: is OK, but does not use sub pixels

editing: tab size is 2, cannot find out how to change

find: find previous next (F3, shift-F3) does not work for me, missing: highlight all, show total number of matches

file format: opening non utf-8 file shows no error (added this to #27)

long lines: no line wrap function, no horizontal scroll bar

vertial scolling: when scrolling up (with cursor up) top line is incomplete shows only a few pixels. cannot disable soft scrolling.

sidebar: cannot resize (but cursor shows <->), cannot disable

tabs: cannot arrange tabs (e.g. drag and drop), cannot find full path name (e.g. have two "init.lua", who is who?)

large files: opening file with 1.2 mio lines and 40MB: eats cpu and memory, 2GB after scolling to bottom and waiting. (compare with notepad3: opens faster, scrolls faster, consumes 80MB)

Q: Would toolbar be considered as core element or addon?

Just as title says. I mean the toolbar at the top of window like usually.

Runs on OSX 10.15.4 but screen resolution is low or very zoomed in

Runs on OSX 10.15.4 but screen resolution is low or very zoomed in

Numpad alternate functions do not work

When num lock is off, alternate functions do not work (direction keys, end, home, pgup, pgdown).

Also: really nice editor! Blazingly fast!

Shift + click text selection

It'd be dope if you could select text from where the cursor is up to the where you click next by holding the shift key.

io.popen flashes cmd.exe window

Linters, gitstatus etc. are very annoying on Windows, because every time there is io.popen invoked, it creates visible cmd.exe window.

File path in save file notification has extra backslashes.