ryank109 / react-redux-popup Goto Github PK

View Code? Open in Web Editor NEW

7.0 7.0 3.0 408 KB

React popup with redux

License: MIT License

JavaScript 96.77% HTML 0.47% CSS 2.76%

modal popup portal redux smart-positioning

react-redux-popup's People

Contributors

Stargazers

Watchers

Forkers

jeffzaccagnini dipenmodi zoryana94

react-redux-popup's Issues

Wrong popup positioning

Hi Ryan!
I use your popup for the app. It's positioned properly on the biggers screen resolutions.
When there is the small screen resolution, It's shown not where it should be.

I'd be thankful if you look at it... maybe, you know some workarounds

Wrong popup positioning in IE

Hi!!!)

After updating the version of the react-redux-popup to 2.7.1 the popup positioning looks incorrect in IE.

I've researched. Maybe, the reason is in the following:

there's an issue of the plugin not being able to properly position the zoom pane on IE 11, because the computation required to assign the top and left values returns NaN.

This can be fixed using window.pageXOffset and window.pageYOffset instead of window.scrollX and window.scrollY. As you can see here, using window.pageXOffset is better for cross-browser compat.

See: imgix/drift#33

Popup within popup doesn't work

I think this is due to physical popup being rendered outside of the <Provider>. Might need a hook to plug this into the main <Provider> and still be on top of everything else.