ryannerd/ember-power-timepicker

An Ember time-picker component that leverages the excellent Ember Power Select for a single purpose

ember-power-timepicker's Issues

Time calculation changes

• init() - Calculated the times[] should use getFormattedTime?
• getFormattedTime() use the zeroPad function?

Assertion is hit when trying to clear the selected time

The following assertion bubbles up when trying to clear the selected time (hitting the cross) picked in the provided 'Simple Example' from the Readme.md:
Uncaught TypeError: timeString must be a non-empty string.
at Class.hours (time-picker.js:463)
at Class.onchange (time-picker.js:17)
at Backburner.join (backburner.js:576)
at Function.run.join (ember-metal.js:4393)
at action.js:389
at exports.flaggedInstrument (ember-metal.js:3787)
at action.js:388
at Class.select (power-select.js:312)
at Class.send (action_support.js:128)
at Class.superWrapper [as send] (ember-utils.js:437)

The configuration is as follows:
{{time-picker selectedTime=timeSelected onchange=(action "onChange") increment=5 }}

import Controller from '[at]ember/controller';

export default Controller.extend(
{
timeSelected: null,
time: null,

actions:
{
onChange(value)
{
this.set('time', value);
}
}
});

Archiving so the broken NPM audit can shut the hell up

NPM Audit is BROKEN!

Add instructions to the wiki

Ultimately will create a webpage that showcases the component.

Looking for someone to take over this project

My company is moving from Ember to React and as such I'm not going to have time for side projects.
If you are interested in owning and maintaining this project let me know by posting an issue.
Going forward only security related fixes will be worked on and published.

onchange is being hit on first load?

When running the example, it looks like onchange is being hit on first load?

Is this normal?

Military time incorrectly starts at 01:00

When using military=true the earliest time I can select is 01:00 and latest time is 24:59. I believe this should be 00:00 to 23:59

Missing triggerClass pass-through property

Hi!

First of all, thank you for creating this addon, I just needed a neat and simple timepicker and stumbled upon yours! Works great!

Ember-power-select has a triggerClass property that can be used to apply a class to the trigger only, and it's really useful (for applying let's say a background icon on the trigger).

It would be great to have the ability to do so with your timepicker.

Let me know if you think it's a good idea!

Thank you!

Firefox is calculating NaN in the hours() and minutes() functions

Chrome works just fine. FF doesn't.

The hours and minutes are derived from:
let date = new Date('1970-01-01 ' + timeString);
Where timeString is the text of the selected time. This works in FF if the time is military but if it has AM/PM then it doesn't.

Allow 24 hour format instead of forcing AM/PM

Update the README with the missing pass-through properties

• closeOnSelect
• loadingMessage
• matchTriggerWidth
• afterOptionsComponent
• beforeOptionsComponent
• triggerClass