Giter Site home page Giter Site logo

Comments (16)

Finii avatar Finii commented on May 29, 2024

Thanks for reporting.
I remember that I fixed that some longer time ago 🤔

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

😳

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

Hmm, I can not reproduce.

Set up like this:

image

Then run LibreOffice Writer:

image
image

There is a difference between mechanics in the Ubuntu Light compared to the other Ubuntu fonts, but you specifically state Ubuntu Mono where no Light is available.

Maybe we should concentrate on a subset of the patched Ubuntu fonts. Please for example remove all Ubuntu Nerd Fonts and Ubuntu Sans Nerd Fonts, leaving only the Ubuntu Mono Nerd Fonts, which are 12 files.
Maybe check also the font versions, not that you have the issue with some old patch.
Important is to restart LibreOffice after changes in the font directory.
Also I never need to rebuild the font cache, your mileage may vary.

from nerd-fonts.

eliminmax avatar eliminmax commented on May 29, 2024

The issue is that the "fi" ligature appears instead of the music note, not the other way around. I think it's the inverse of the previous issue you linked.

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

Ah you assed your spreadsheet file, excellent 👍

image

image

image

You did enter a codepoint directly, i.e. F001, and that is indeed the musical note.
Why do you think that is the fi ligature?

It's not, the fi ligature is at FB01 in the Ubuntu fonts (at least in most).

The ligature lookup table says the ligature glyph name is f_i, and that is here:

image

The glyph at F001 has the name fi and THAT is not referenced my anything inside the font.

image

So, the question is, why do you insert some concrete codepoint, if you want the ligature you just type f and i and let the font do its magic? And IF you enter a codepoint, enter the correct one?

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

The issue is that the "fi" ligature appears instead of the music note, not the other way around. I think it's the inverse of the previous issue you linked.

Ah, sorry, now I seem to understand 😅 , let me explain:

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

In the (few) Ubuntu fonts where at F001 is not a musical note we can not remove that glyph without breaking the font.

If - in those fonts - the glyph would be patched to the music note glyph, and someone types f followed by i it would display the note. That is a ligature rule inside the font file and we can not easily change that.

We could remove the ligature rule, leaving the f and i as individual glyphs, but then the font is not intact anymore and looks bad where people expect a better looking ligature glyph.
We could take the ligature glyph and move it to some other codepoint, and then adjust the substitution tables in the font. But that is very hard to do automatically.
So we choose to not patch over 'essential' glyphs. Patching those glyphs breaks the font because of its substitution rules.

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

If you want to self-patch I can give you the patcher config to remove the ligature.

And when the ligature is removed the patcher notices that the glyph can be replaced by the note glyph.

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

Hmm, I am a bit too dump (maybe sleep deprivation),

can reproduce finally 😬

image

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

Thanks for reporting and nudging me in the right direction 👍

from nerd-fonts.

eliminmax avatar eliminmax commented on May 29, 2024

I understand. I might just switch to a different Nerd Font.

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

Ubuntu

image

Ubuntu Mono

image

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

@allcontributors please add @eliminmax for bug

from nerd-fonts.

allcontributors avatar allcontributors commented on May 29, 2024

@Finii

I've put up a pull request to add @eliminmax! 🎉

from nerd-fonts.

Finii avatar Finii commented on May 29, 2024

There was even a real bug in the code - UbuntuMono should never have had the fi-ligatures preserved (because it just had the glyphs but no rules in the font file to access them as ligs).

from nerd-fonts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.