Giter Site home page Giter Site logo

Comments (5)

ryanoasis avatar ryanoasis commented on May 22, 2024

@SageEx Thanks for the info and I am glad this project is useful to you 😄

python 3

I will have to look into that, I see the changes you had to make. There has to be a way to make it compatible for py3 and py2 without having 2 separate scripts to maintain?

how about including Fantasque Sans Mono in the default patched fonts set ?

Looks like the license will allow this (OFL (SIL Open Font License)), the only I was checking for is if there is a Reserved Font Name specified in the license but I don't see one. If the name is reserved we would just have to rename the patched version (e.g. Hack becomes Knack).

from nerd-fonts.

SageEx avatar SageEx commented on May 22, 2024

Most of the changes are due to the convention changes from python2 to python3 - like

  • brackets in print statements
  • dic.iteritems() to dic.items
    etc.

I doubt that a single python script would suffice.

Rather, as a solution, you can maintain the python2 script only and use 2to3 to automatically generate the python3 script. The only manual change you will have to make in the generated script is to revert the change at line 306. By default 2to3 will change from Unicode to str - but str is not an attribute - hence the error. Any way to use 2to3 which does not change this will be the answer to this problem.

I really hope to see the Fantasque Sans Mono font in the repo.

Thanks again for this repo - along with vim-webdevicons.

from nerd-fonts.

ryanoasis avatar ryanoasis commented on May 22, 2024

Thanks btw. I will probably get to this but not anytime soon.

Fantasque Sans Mono

Probably not too difficult to add just a handful of bugs that I've been focusing on.

Cheers!

from nerd-fonts.

ryanoasis avatar ryanoasis commented on May 22, 2024

I don't have fontforge setup with py3 bindings nor have it compiled with py3 so I cannot test however this script: font-patcher-py3 should work for python3, if someone could test it out? That'd be great!

fontforge -script font-patcher-py3 unpatched-sample-fonts/Monoid/Monoid-Italic.ttf --powerline --powerlineextra
or
python3 font-patcher-py3 unpatched-sample-fonts/Monoid/Monoid-Italic.ttf --powerline --powerlineextra

This is only on the 0.7.0 branch for now.

I will test it when I get a chance.

from nerd-fonts.

github-actions avatar github-actions commented on May 22, 2024

This issue has been automatically locked since there has not been any recent activity (i.e. last half year) after it was closed. It helps our maintainers focus on the active issues. If you have found a problem that seems similar, please open a new issue, complete the issue template with all the details necessary to reproduce, and mention this issue as reference.

from nerd-fonts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.