ryanpig/finviz-rs

Collect financial information from finviz website

finviz-rs's Issues

OrderType, SignalType enums are not copyable

For example, when writing this piece of code:

pub struct FinvizHelper{
    signal: SignalType,
    order: OrderType,
}

impl FinvizHelper{
    pub async fn get(&self) -> Result<(),Box<dyn std::error::Error>> {
        Screener::new(ScreenerType::Overview)
            .set_signal(self.signal)
            .set_order(self.order)
            .scrape().await?
            .to_csv_file("output.csv")?;
        Ok(())
    }
}

The members self.signal and self.order are not copyable because their matching types are not copyable, therefore there's implicit move, but the required behavior here is copy.

Solution:
change current #derive of SignalType, OrderType to #[derive(Copy, EnumIter)]

Error: "Cannot find News table" in news example

The error occurs because of parsing error of table elements

Error: "Cannot find News table"

Desc order should be added to OrderTypes

On finviz it is possible to sort stocks not only by ascending order, but also by descending order.
Solution:
OrderType::Ticker => "o=ticker",
===>

OrderType::TickerAsc => "o=ticker",
OrderType::TickerDesc => "o=-ticker",

(should be done for all OrderTypes)