rythos42/ladder

ladder's Issues

Able to have discussion on a claim, before endorsing

Endorsement count on badges doesn't update when you endorse a skill

"Badge" for count of skills YOU endorsed for someone else

Show skill level on Claims page

When evaluating someone, it's better if we have more information against which to evaluate them.

Make Azure auth more configurable

Currently the Azure details are hard coded in auth-utils.js, they should be put into config.json and read from the Redux store.

Badge should only show claims that have been endorsed

Filter by "Level"

Filter by Claimed

Able to show both claimed skills and unclaimed skills.

Profile: Show time claim was created

Remove auth debug panel/etc

It isn't necessary

Have endorsement e-mail link to claims page

Presently it links to the main page, which isn't as useful.

Send e-mail to people who you've asked to endorse your claim

So they know there's a thing waiting.

Ability to view other peoples profile pages

Something for a team lead to look at

Toast showing new skill added

Toast showing endorsement was submitted

Hide "Add Skill" button if not signed in

More skill "Details"

May want to provide more details on skills. Show them in like an expansion panel on the skills page and on endorsements so they are more visible.

Ability to add more endorsers to claim after it has been started

Wondering about if someone isn't sure about a claim, and whether they want to bring in additional points of view.

Claims: Show who was asked to endorse

Currently can't see it.

Is there an Azure profile photo?

Have some skills require multiple endorsers

Profile: Show whether claim was endorsed or not

Prevent skills from being edited unless has permission

There's some great stuff here, but I don't have Azure permission to create custom roles.

Wondering if we can:

• Add scopes to app registrations
• Provide scopes to custom roles
• Ask for those scopes when we log in
• Check the scope was granted when we perform an action

This could be a great model for how I'm thinking JUDI should work, if it works.

Here's some resources:
https://docs.microsoft.com/en-us/azure/active-directory/users-groups-roles/roles-create-custom#create-a-new-custom-role-to-grant-access-to-manage-app-registrations

https://docs.microsoft.com/en-us/powershell/module/azuread/connect-azuread?view=azureadps-2.0

https://www.andrewconnell.com/blog/leverage-custom-permissions-in-azure-ad-applications/

Show evidence on the claims page

You can't currently see what evidence someone is providing for their claim.

Autocomplete e-mails

Use the Microsoft Graph to do it!

Here's some sample code I ripped out of the MS sample that might lend itself into a good direction:

`Request Email token flow

Request Email Permission

    async onRequestEmailToken() {
const tokenResponse = await this.acquireToken(GRAPH_REQUESTS.EMAIL).catch(
  e => {
    this.setState({
      error: "Unable to acquire access token for reading email."
    });
  }
);

if (tokenResponse) {
  return this.readMail(tokenResponse.accessToken);
}

}

async readMail(accessToken) {
const emailMessages = await fetchMsGraph(
GRAPH_ENDPOINTS.MAIL,
accessToken
).catch(() => {
this.setState({
error: "Unable to fetch email messages."
});
});

if (emailMessages) {
  this.setState({
    emailMessages,
    error: null
  });
}

}`

Have some skills require multiple pieces of evidence

Make starter skill SQL not hardcode my username

User profile page

Top X recent claimed skills
Top X recent endorsed skills
Top X recent skills you've endorsed
Username
Profile photo from Azure?

Allow user to see comments on previous claims

This may be a separate profile page, or it may be an expandable panel off of the Skills page, which will be more easily viewable when filtering to show only claimed skills.

Be more explicit about how the user is not signed in

There's to much that's visible and looks usable ("no claims to endorse") when the user isn't signed in, it isn't obvious what you need to do.

Toast showing claim was submitted

Add audit table

With skills being able to be edited, it's probably a good idea to be able to see who edited them.

Could maybe remove the AddedByUsername and AddedOn from Claim and put this into the audit table instead.

Show recent claimed skills on profile page

Show notifications "bell" with a number of notifications for a logged in user

Consider if we need a skill "type"

Like "dev", which might allow other parts of the company to take part.

Refactor Claim to use Message entity

Instead of having a column for a message, just use the message entity more?

Allow skills to be edited

I'd like to iterate over skills, and editing will allow us to do that easily.

Make deployment not suck

UI deployment is;

• yarn build
• deploy using Azure App Service in VSC, but only if you have the publish file on my local computer
• (Optional) update config.json in ladder-ui to point to https://ladder-server.azurewebsites.net
  • This file doesn't get re-deployed, so doesn't get copied over and doesn't need updating.

Server deployment is:

• stop web app
• publish in VS, but only if you have the publish file on my local computer
• update appSettings.json in ladder-server
  • ConnectionString Server=tcp:jdi-sql-dev.database.windows.net,1433;Initial Catalog=ladder;MultipleActiveResultSets=True;Encrypt=True;TrustServerCertificate=False;Connection Timeout=30;
  • LadderSiteUrl https://ladder-ui.azurewebsites.net/
• start web app

Make Level configurable

Profile: Show skills you recently endorsed

Search skills

"Badge" for count of skills

Profile: Tab indicator incorrect

It says you're on one of the tabs, which you aren't.

Add some starter skills

I wondered if it would start organically, but it seems it won't. So it's probably a good plan to seed the database with some basic skills, perhaps from the Renttherunway ladder, so people have an idea of how to start.

Remove Toolbar in Header

Looks better and interface has more available space without it.

Need to resize the icons as well so the badges fit

Refactor GetClaimsForNotUser and GetClaims in ClaimRepository

These two functions are too similar, differing only in the where clause. I couldn't make it work easily, so I copied it instead.

Use some kind of generic e-mail for the "From" address

Refactor Filter to not need to supply every filter parameter

This code will get silly in the next filter added:

`
setSummaryFilter = evt => {
this.setState({
filter: {
summary: evt.target.value.toLowerCase(),
levelId: this.state.filter.levelId
}
});
};

setLevelFilter = evt => {
this.setState({
filter: { summary: this.state.filter.summary, levelId: evt.target.value }
});
};
`

Put a "help" dialog up somewhere with a description of how the system is intended to work

Profile: Show your skills recently endorsed

Spelling mistakes in RentTheRunway skills

ffectiveness
Recgognized