s1syphos/kirby-lingonberry

A Kirby port of the Wordpress theme 'Lingonberry'

kirby-lingonberry's Issues

Making Gravatar support optional

Hi,
an option to disable gravatar support (comments-area), would be nice.

thx

no blog entries - error with site/templates/home.php?

Hi,
the last update of site/templates/home.php killed the frontpage.

old version works for me to show blog posts on first page. but pagination still does not work on other pages.

coverimage() for pages

missing /assets/images/2x/post-formats/image.png

Hi,
jquery.js wants to load /assets/images/2x/post-formats/image.png but this file does not exist.

greetings

Make Categories optional (enhancement idea)

Hi,
since the original Template was for wordpress, it supports both, tags and categories.
There are many people that find it difficult to differentiate between tags and categories. Also minimalism in UI is worthwhile. So maybe it is possible to get categories and/or tags to be optional, by enabling/disabling them in options.

would be nice feature

thx
demlak

Call to a member function firstName() on null

If there's an author of a post, but he hasn't defined first / last name yet, you'll receive an error.
Otherwise, I'm having all fun no trouble, great plugin.

thx

Adding comment count & anchor link to `meta.php`

table alignment - unwanted behavior

hi,
i tried to generate some tables with alignment. i need several tables wich are aligned on cells, that are at the same size. In the following example all cells on the 3rd column are all the same size. i tried to align them to the right site. the cells on the 2nd column should now align on the right site. the collumn should have exactly all the same distance to the 3rd column, but they don't. The distance seems to depend on the width of the 2nd column/cell

example 1 markdown:

|Table Header 1|Table Header 2|Table Header 3|
|---|---:|---:|
|Division 1|Division 2|Division 3|
|Division 1|Division 2|Division 3|
|Division 1|Division 2|Division 3|


|Table Header 1|Table Header 2|Table Header 3|
|---|---:|---:|
|Division 1|Divisifdsgfdsgon 2|Division 3|
|Dividsadsadsadsadassion 1|Divisgfdsgfdsgsion 2|Division 3|
|Division 1|Divfdsgfdision 2|Division 3|


|Table Header 1|Table Header 2|Table Header 3|
|---|---:|---:|
|Division 1|Division 2|Division 3|
|Division 1|Divisfdsgfdsgion 2|Division 3|
|Divisdsadsadsadsadasdion 1|Divisfdsgfdggfdgfdgion 2|Division 3|

example 1 picture:

In the 2nd example i tried to align the 2nd column to the left, where all cells of the 1st colum are all the same size. a similar effect happens. again, the column alignment seem to depend on the column width.

example 2 markdown

|Table Header 1|Table Header 2|Table Header 3|
|:---|:---|---:|
|Division 1|Divisiodsafdsafdsn 2|Division 3|
|Division 1|Division 2|Divisiofdsafdsafdsn 3|
|Division 1|Division 2|Division 3|

|Table Header 1|Table Header 2|Table Header 3|
|:---|:---|---:|
|Division 1|Divisidsfdsfon 2|Division 3|
|Division 1|Divisfdsafdsfion 2|Division 3|
|Division 1|Division 2|Divisdsfdion 3|

|Table Header 1|Table Header 2|Table Header 3|
|:---|:---|---:|
|Division 1|Division 2|fdsf 3|
|Division 1|Division 2|Division 3|
|Division 1|Dividfsfdssion 2|Division 3|

example 2 picture:

Since i don't know if this is a problem on kirby itself or on the lingonberry theme, i just started in here, before i head over to the getkirby forum, if necessary.

thx in advance

Global (shared) controller?

https://forum.getkirby.com/t/shared-controller/1839
https://forum.getkirby.com/t/shared-controller-not-working/9091
https://forum.getkirby.com/t/kirby-init-controller/4038/2
https://forum.getkirby.com/t/inherit-controller-controllers-that-inherit-from-the-site-controller/5103/4

Table issue

Hi,
never saw this before.. but there is a glitch in the first row on each table:

see live: https://0ma.de/home/mein-bike

Suggestions

@S1SYPHOS: Since you asked, here are a few things 😉

• What baffles me most is the utter lack of semantic HTML elements, it's divs all over the place.
• Why are there all these empty divs to clear floats? If you really want to stick with floats instead of using flexbox, for example, I'd use a standard clearfix class.
• jQuery for those few lines of JS?
• Don't use user-scalable:no
• Use svg (sprites) instead of 1x/2y PNGs
• srcset for images where applicable

RSS-Feed does not Include Intro - fix inside

Currently, the rss-feed does only include the text field.
In most cases, this will split the intention of a blog post on the rss feed.

To include Intro field on demand, in site/plugin/feeds/template.php change the following line:

<description><![CDATA[<?php echo $item->{$textfield}()->kirbytext() ?>]]></description>

to

<description><![CDATA[<?php if($item->intro()): ?><?php echo $item->intro()->kirbytext() ?><?php endif ?><?php echo $item->{$textfield}()->kirbytext() ?>]]></description>

#19

opengraph with lingonberry - 'kirby-meta-tags'-example-config

Hi, i want to give something back =)

Since i want nice inclusion of my postings/website on social media sites, i was playing a little bit with this nice plugin: https://github.com/pedroborges/kirby-meta-tags

i was able to make a config, which generates nice meta tags for blog posts and for the main-site.
i was not able to get deeper into it, so there are still some things missing. for example coverimage for gallery posts. Also videos are not referenced when added in the video template via Embed code. And Kirby-Tags are also not added.

if there is no coverimage, the default site-logo will take place.
if there is no page text, then the default site description takes place.

well.. here is my config, that works for example with twitter card validator
(as i did not saw any benefit on using twitter-card-meta-tags, i just use opengraph tags)

c::set('meta-tags.default', function(Page $page, Site $site) {
    return [
        'title' => $site->title(),
        'meta' => [
            'description' => $site->description()
        ],
        'link' => [
            'canonical' => $page->url()
        ],
        'og' => [
            'title' => $page->isHomePage()
                ? $site->title()
                : $page->title(),
            'type' => 'website',
            'site_name' => $site->title(),
            'url' => $page->url(),
            'description' => $page->isHomePage()
                ? excerpt($site->description(), 280)
                : (
                    $page->intro()->empty()
                    ? excerpt($page->text(), 280)
                    : excerpt($page->intro(), 280)
                  ),
            'namespace:article' => [
                 'author' => $page->author(),
                 'published_time' => $page->date('c'),
                 'modified_time' => $page->modified('c'),
            ],
            'namespace:image' => function(Page $page, Site $site) {
                $image = $page->coverimage()->toFile();
                return $image
                ? [ 'image' => $image->url() ]
                : [ 'image' => $site->logo()->toFile()->url() ];
            }
        ]
    ];
});

line spacing on image alignment

Hi, i just saw, that line spacing differs, when there are images aligned by class "alignright", "alignleft" and "aligncenter" and there is no "new line" before image-tag (same <p>-tag). Also text after the image-tag is not shown on website (kirbytext ignores it?) when there is no new line after image-tag. Maybe this is not changeable markdown behaviour, maybe it is. I just want to let you know =)
line spacing is good, when image-tag is written in it's own line

See screenshot

showing excerpt instead of full post

Hello everyone!
I have a question, is it possible to show just the excerpt on the homepage, instead of the whole post.

Thanks!

Some initial issues

Hi,
just installed the theme for a test.. looks nice.. thx a lot
but there are some initial problems:

1. pluginfolders "images" and "quickselect" are empty
2. you need a user called "admin" to get started with pre-defined testposts. this would be a nice info at the readme.

since i'm not familiar with github, i don't know how to submit this beside this issue report.. so i'm sorry for this way of submission. but i think it will be helpfull.

thx

Writing docs for available theme options

Alt attribute handling

<img src="<?= $image->resize(766, null, 85)->url() ?>"<?php e($image->alt()->isNotEmpty(), ' alt="' . $image->alt()->html() . '"') ?>>

If the alt field is empty, the image will not have an alt attribute. However, the alt attribute should always be present even if empty for accessibility reasons.