sadikoff/artemisodoctrineextra

Work with gedmo/doctrine-extensions is simple!

Hi there 👋

artemisodoctrineextra's Issues

[Insight] Text files should end with a newline character - in Utils/Transliterator.php, line 16

in Utils/Transliterator.php, line 16

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

    }

    public function transliterate($text)
    {
    }
}

---

Posted from SensioLabsInsight

[Insight] Version of dependencies should be fixed

Package umpirsky/transliterator#dev-master is not fixed.

---

Posted from SensioLabsInsight

[Insight] Text files should end with a newline character - in composer.json, line 36

in composer.json, line 36

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

    "autoload": {
        "psr-4": {
            "Artemiso\\DoctrineExtraBundle\\": ""
        }
    }
}

---

Posted from SensioLabsInsight

[Insight] Text files should end with a newline character - in Traits/PersonalTranslation.php, line 35

in Traits/PersonalTranslation.php, line 35

This file ends with no newline character. It won't render properly on a terminal, and it's considered a bad practice. Add a simple line feed as the last character to fix it.

            $this->translations[] = $translation;
            $translation->setObject($this);
        }
    }

}

---

Posted from SensioLabsInsight

[Insight] The Symfony Dependency Injection Container should not be passed as an argument - in Listener/DoctrineExtensionListener.php, line 16

in Listener/DoctrineExtensionListener.php, line 16

A Symfony dependency injection container has been found as an argument.

    /**
     * @var ContainerInterface
     */
    protected $container;

    public function setContainer(ContainerInterface $container = null)
    {
        $this->container = $container;
    }

    public function onLateKernelRequest(GetResponseEvent $event)

---

Posted from SensioLabsInsight

[Insight] Unused use statement should be avoided - in …/DoctrineExtensionLoggableListener.php, line 6

in Listener/DoctrineExtensionLoggableListener.php, line 6

The class Symfony\Component\HttpKernel\Event\GetResponseEvent is declared but never used. You should remove the use statement.

<?php

namespace Artemiso\DoctrineExtraBundle\Listener;

use Gedmo\Loggable\LoggableListener;
use Symfony\Component\HttpKernel\Event\GetResponseEvent;
use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
use Symfony\Component\Security\Core\Authorization\AuthorizationChecker;

class DoctrineExtensionLoggableListener
{

---

Posted from SensioLabsInsight