sadikoff/crud-maker-bundle

Generate symfony flex crud is simple!

Hi there 👋

crud-maker-bundle's Issues

require --dev security-csrf and form for this package?

since won't work without security-csrf and form
should these be added to compoer require --dev for this package?

.. matt ..

sequence wrong in controller methods - /<entity>/new parsed as /<entity>/id for show

the NEW controller method should be BEFORE the SHOW controller method in the controller template

since
//new
is parsed by the SHOW method as
/{id = 'new'}
which then fails with an Object Not found ParamConverter annottion exception

SOLUTION:

locate the new() method BEFORE the show() method in: Controller.tpl.php

I'm new to PUll reuqests for open source stuff - but I'll try to set one one via a fork :-)

.. matt ..

wrong method for DELETE (_DELETE instead of DELETE)

_delete_form.tpl.twig currently:

<form method="post" action="{{ path('<?= $route_name; ?>_delete', {'<?= $entity_identifier; ?>':identifier}) }}" onsubmit="return confirm('Are you sure you want to delete this item?');">
    <input type="hidden" name="_method" value="DELETE">
    <input type="hidden" name="_token" value="{{ csrf_token('delete' ~ identifier) }}">
    <input type="submit" value="Delete">
</form>

should be:

<form method="post" action="{{ path('<?= $route_name; ?>_delete', {'<?= $entity_identifier; ?>':identifier}) }}" onsubmit="return confirm('Are you sure you want to delete this item?');">
    <input type="hidden" name="_method" value="DELETE">
    <input type="hidden" name="_token" value="{{ csrf_token('delete' ~ identifier) }}">
    <input type="submit" value="Delete">
</form>

i.e. method should be DELETE (with no underscore prefix)

Show route hijacks the new route

when you generate code for an entity all works well apart from the new route. It seems to be matching that route to the show action. Am thinking this might be solved by moving the new action above the show action.
According to https://symfony.com/doc/2.6/book/routing.html#book-routing-conditions earlier routes win. Tried it and it worked on 1 controller, don't know if there are bigger considerations. Once again good work.

unimplemented abstract method? - fatal error

/MakeCrud.php on line 29

!!
!! Fatal error: Class Koff\Bundle\CrudMakerBundle\Maker\MakeCrud contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (Symfony\Bundle\MakerBundle\MakerInterface::generate) in .../testing02_unit/vendor/koff/crud-maker-bundle/src/Maker/MakeCrud.php on line 29
!!

missing method generate() ??

handleRequest() not resulting in isSubmitted for DELETE method

clicking a DELETE button in the Edit form doesn't result in
isSubmitted() being true after a handleRequest()
so the actions to remove/flush the entity aren't executed, and no delete from DB takes place

to get this to work I had to add in a condition to submit the form, adopting example from Symfony docs

but should this be necessary?

if required, then we need to update the Generated code for the Controller ...

    public function delete(LoggerInterface $logger, Request $request, Category $category)
    {
        $logger->info('1 :: got here');

        $form = $this->createDeleteForm($category);
        $form->handleRequest($request);

        $logger->info('2 :: isSubmitted = ' . $form->isSubmitted());

        if ($request->isMethod('DELETE')) {
            $form->submit($request->request->get($form->getName()));

            if ($form->isSubmitted() && $form->isValid()) {
                $logger->info('3 :: in the DELETE bit');
                $em = $this->getDoctrine()->getManager();
                $em->remove($category);
                $em->flush();
            }
        }

Can I overwrite the twig templates?

I'd like to know if there's any way to overwrite the twig templates without having to modify the bundle you've made.

thanks and great work

Delete action is broken if csrf is off

If csrf and session are disabled delete action can't handle request and proceed with deletion

partial Twig templates not created

these lines missing from MakeCrud->getFiles()

            __DIR__.'/../Resources/skeleton/templates/_form.tpl.php' => 'templates/'.$params['route_name'].'/_form.html.twig',
            __DIR__.'/../Resources/skeleton/templates/_delete_form.tpl.php' => 'templates/'.$params['route_name'].'/_delete_form.html.twig',

so Twig include error when running

.. matt ..