Giter Site home page Giter Site logo

Comments (2)

alberto-valdeolivas avatar alberto-valdeolivas commented on May 25, 2024

Hello Ben,

Many thanks for your comment and for the pull request you created. This is indeed a very interesting point and it could be an appealing functionality to add to the package. However, I wonder if the option to export paths to JSON format would be more suitable in a more general package like igraph. In our package, we mainly retrieve the information from the Omnipath webservice and we transform it to data frames and igraph objects. Indeed, your functions deal with objects from the igraph package. It seems that a discussion about Import/Export graph as JSON files already took place for the igraph package:

igraph/igraph#957

On the other hand, we are currently submitting our package to Bioconductor so we cannot include the new functionalities you proposed right now. I will merge your pull request to a new branch.

I will also discuss with my colleagues about including your functions to our package and come back to you.

Best regards,
Alberto.

from omnipathr.

hallba avatar hallba commented on May 25, 2024

Hi Alberto

Thanks for your feedback. iGraph is inappropriately general for this type of export- here we need to build models that take information from OmniPath directly into account (here the PMID and associated upstream elements).

I've developed a more powerful example of model export from omnipath (leaving out R entirely), available here https://github.com/hallba/Z3Tutorials (see minimumGenes.fsx). This takes a set of genes, calculates the minimum set required to link them, makes a layout and exports the json to the clipboard.

Ultimately it may be appropriate to link BMA to OmniPath, but in the meantime these scripts make OmniPath more useful for network modelling.

best wishes

Ben

from omnipathr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.