saghm/json-color

Rust library to colorize JSON strings

json-color's Issues

Incorrect handling of special characters in strings

extern crate json_color;

use json_color::Colorizer;

fn main() {
    let colorizer = Colorizer::arbitrary();

    println!("{}", colorizer.colorize_json_str("\"a\\nb\"").unwrap());
}

Expected:

"a\nb"

Actual:

"a
b"

Since you are using serde_json anyway, consider implementing json-color as a Formatter to take advantage of our logic for rendering escape sequences, among other things. Something like:

pub fn colorize_json_str(&self, s: &str) -> Result<String, Error> {
    let mut wr = Vec::new();
    let formatter = ColorFormatter { colorizer: self, indent_level: 0 };
    {
        let mut de = serde_json::Deserializer::from_str(s);
        let mut ser = serde_json::Serializer::with_formatter(&mut wr, formatter);
        serde_transcode::transcode(&mut de, &mut ser)?;
    }
    Ok(String::from_utf8(wr).unwrap())
}

A good starting point would be rq's colorizing formatter implementation. Note that every method has a sensible default implementation so you would only need to override the ones that need to be colored.

@saghm

Option to highlight escape sequences by default

This feature is really helpful in many editors.

Consider add non-pretty output.

I want to output colored json string on one line, but we seem to only support pretty output now.

Colored output broken when piping due to changes to `colored` crate

The colored crate now performs some checks to determine whether it should enable colored output (which feels sort of wrong to me as the default, but IDK): colored-rs/colored#69

The solution seems to be to use colored::control::set_override(true). I think it'd probably be fine to call this at a fairly high level given that the entire purpose of this crate is to output colorized JSON.