Color look a bit washed

[sainnhe]

Color look a bit washed

[sainnhe]

What I don't understand is why meta.object-literal.key.js is green in your screenshot, this is what it looks like in my vscode:

But it needs to be tweaked indeed, I made a slight adjustment to it:

What is your vscode version? Have you installed any syntax extensions that might affect the javascript syntax highlighting? This theme is currently only optimized for built-in js syntax highlighting.

[GulajavaMinistudio]

I dont know why is different from your screenshot. Im using JavaScript ES6 Snippet and Babel JavaScript extension. My VS Code version is 1.40.0 .

[sainnhe]

I've tried mgmcdermott.vscode-language-babel, it reproduced.

Sorry but I won't optimize this syntax extension, because I think it's very bad. This is the built-in js syntax highlighting:

As you can see, in mgmcdermott.vscode-language-babel, the code scope is string.unquoted.js, while in the build-in js syntax highlighting, the code scope is meta.object-literal.key.js. This means that in mgmcdermott.vscode-language-babel, the code is logically related to unquoted string.

In vscode, string.unquoted.js inherits from string.unquoted, and string.unquoted inherits from string. I personally think any scopes related to string should be green(or maybe white), so the fact that string.unquoted.js is green is logical, but it's obviously illogical this case. I guess the author of this extension has put a lot of other code in this scope.

I suggest you uninstall this extension and use build-in js syntax highlighting instead, microsoft has done a very great job in js syntax highlighting. The build-in js syntax highlighting is logical and accurate, and every element can be highlighted.

[GulajavaMinistudio]

Thanks for response and solution from you.
And one more thing, here some reference for material colors, i think the fit palette is between 500 - 700 . For example Green 500, Red 500, etc

You can check palette in here.
Material Palette

[sainnhe]

Thanks for your link.

I have tried to use existing material palettes directly, but the effect is not good. Many material palettes are mainly designed for UI colors instead of foreground colors, so there are some very serious problems when using as foreground colors. To sum up, they're not eye-friendly at all. Please forgive me for saying so straightforward, but this is the truth.

The current color palette has been carefully adjusted many times based on the original gruvbox and has been tested on several devices, and works very well with redshift and f.lux .

But I think it is currently far from perfect, there might be some adjustments in the future. If you have any ideas or suggestions, welcome to share them in #11.