Giter Site home page Giter Site logo

Comments (6)

nmussy avatar nmussy commented on June 26, 2024 1

Yes, what you describe was what I had in mind.

And I agree about the backwards scrolling, it would have been nice to have, but it's definitely not as important.

from discogs-enhancer.

nmussy avatar nmussy commented on June 26, 2024 1

I force updated the app, and both issues LGTM. Thanks for the quick response and update!

from discogs-enhancer.

salcido avatar salcido commented on June 26, 2024

@nmussy Just to clarify - you want the URI to update the page param whilst scrolling?

i.e.:

  • You begin at page 1 and scroll to page 2
  • URI updates with &page=2
  • Scroll to page 3
  • URI updates with &page=3

Is that correct?

Edit: After looking into things, adjusting the page param when scrolling backwards seems rather difficult and I'm not sure the level of effort required to implement it is worth it? That being said, updating page with the most recently queried page should be fairly simple.

from discogs-enhancer.

salcido avatar salcido commented on June 26, 2024

Ok, I merged a fix for everlasting marketplace but the collection will take a few more days since I need to test with a user who has more than 2500 items in their collection. I'm going to test these updates and make sure nothing is broken then I'll push out an update to the Chrome Store.

from discogs-enhancer.

salcido avatar salcido commented on June 26, 2024

I pushed out an update to the Chrome web store. It should update automatically sometime in the next 24 hours. New version is 2.14.1. Let me know if you run into any issues!

from discogs-enhancer.

salcido avatar salcido commented on June 26, 2024

Sure thing :) thanks again for opening up the issues!

from discogs-enhancer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.