Comments (7)
Oh, and it's a small nitpick, but I don't think "recycling" Unicode symbol is the clearest representation of a random element. I think either the gamedie (🎲) or twisted rightwards arrows(🔀) character would be easier for new users to understand
from discogs-enhancer.
Hey @nmussy,
That's a good call, I can update that to a proper anchor
so it can be opened in separate tags.
As for the icon, I initially wanted to use the twisted rightwards arrows
but Chrome (or OS X, not sure which) automatically uses the Emoji version which does not match Discogs style guide. Personally, I don't think Emoji should represent UI elements, so I went with the recycling
icon since it was a better match with Discogs' style guide aesthetics.
I may be able to use the Dice icon that is currently used in the React version of the Collection. I'll poke around a bit and see what I can come up with.
Thanks for the suggestions!
from discogs-enhancer.
Hey @salcido,
Yeah, I suggested looking at the event properties because it seemed simpler/more efficient than pre-rendering the anchor with the correct URL. But if you can manage it, it'd also fix the context menu "Open
in a new tab", "new window" etc.
And fair enough for the emoji forms, but you can always force the VS15 text variant by appending ︎
to the unicode character, e.g. 🎲︎
from discogs-enhancer.
And fair enough for the emoji forms, but you can always force the VS15 text variant by appending ︎ to the unicode character, e.g. 🎲︎
TIL. That's pretty cool! I messed around a bit with that but still wasn't able to force the plain text version. Think I'll make an SVG of the twisted rightwards arrow
icon as I like that a bit more than the gamedie
.
While looking into this I realized Discogs has a specific URL just for random items so I'm able to simplify the script quite a bit and ditch the old async
POST method I was using previously.
from discogs-enhancer.
That's unfortunate about the text varient, it works perfectly well on Chrome/Windows 10 :
And glad to hear about the random URL
from discogs-enhancer.
Ok, just published an update to address this! Going to close this ticket ✌️
from discogs-enhancer.
from discogs-enhancer.
Related Issues (20)
- Feature Request: Firefox Port HOT 4
- Feature Request: Wantlist Price Filtering HOT 2
- All tests are skipped? HOT 2
- Feature Request: See full size image HOT 5
- Feature Request: only show specified media formats HOT 2
- Possibility to add custom CSS? HOT 1
- Discogs.com subdomains: not dark-mode enabled HOT 2
- Possible to change the Inventory link to have the same settings each time? HOT 2
- Request: Sort a Items For Sale page by price including shipping. HOT 1
- Feature Request: Show if you already own another edition of a release HOT 1
- Error fetching price average HOT 5
- Missing text backgrounds on Digs HOT 1
- Feature Request - Revert Master Record listing to old style HOT 8
- Feature Request: Load multiple market pages at the same time HOT 2
- Release scanner not showing anymore on new artist pages HOT 8
- Push history "page" search parameter in everlasting pages HOT 6
- Initialize everlasting page index according to search parameter HOT 3
- Feature request: Whitelist and blacklist continents HOT 2
- Bug: "Random item" keeps spinning when you open a new tab HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from discogs-enhancer.