saltstack/istr

Case-insensitive string matching

istr's Issues

Appveyor fails when upgrading pip

• istr version: 1.0.1
• Python version: 3.5
• Operating System: Windows on Appveyor CI

Description

PR #182 fails on Appveyor, see this log https://ci.appveyor.com/project/saltstack-public/istr/builds/29210960/job/8nm77kj7yqhem5go

<Reason is that pip is attempted to be upgraded using the pip command itself, which is locked on Windows.

This can be fixed by changing "pip install" to "python -m pip install".

Initial Update

Hi 👊

This is my first visit to this fine repo, but it seems you have been working hard to keep all dependencies updated so far.

Once you have closed this issue, I'll create separate pull requests for every update as soon as I find one.

That's it for now!

Happy merging! 🤖

Support for Python 3.6 and higher

• istr version: 1.0.1
• Python version: 3.6, 3.7, 3.8
• Operating System: any

Description

The istr package currently declares support for Python version 3.5 only. It should add support for Python versions 3.6, 3.7 and 3.8. Presumably, that is for free and only requires updating the classifiers in setup.py, plus the tested environments in Travis, Allveyor and tox.ini.

Test coverage is only 53%

• istr version: 1.0.1
• Python version: N/A
• Operating System: N/A

Description

The coverage tests report a coverage of 53%. A class of this complexity should have 100%.

Support for Python 2.7

• istr version: 1.0.1
• Python version: 2.7
• Operating System: any

Description

Despite the fact that Python 2.7 wil be declared end of life in 1/2020, there are numerous projects out there that still support it. If any of those wants to start using istr, the main inhibitor will be that istr does not support 2.7. My own Python projects are all of that category :-)

I think what it takes to add Python 2.7 support is:

• using six.text_type instead of str (or because nothing else would be used of six, a simple type definition that mimics that).
• replacing str.casefold() with str.tolower()

Docs are very minimal

• istr version: 1.0.1
• Python version: N/A
• Operating System: N/A

Description

It is great that the docs are on RTD, but there are several issues with the current docs:

• The Usage chapter does not show any usage after showing how to import the package.
• There should be a reference chapter that shows the class with its methods. It is important to understand which methods exactly have the case insensitive behavior, just in case Python adds one.
• There should be some statement about memory use and performance to be expected.
• From the docs, it does not become clear whether this is for byte strings of for unicode strings.
• There is no clear statement on the docs that this is Python 3 only.