Comments (4)
Thanks for your suggestion, but I'm not sure we will add these shortcuts to the repository.
Using default injectors is basically a bad idea since it makes your code very hard to test. Adding 18 more helpers without the i *do.Injector
argument seems excessive to me.
Anyway, you can use a simple alias in your projects:
// utils/do.go
func Provide(provider do.Provider[T]) {
return do.Provide(nil, provider)
}
I keep this issue open for further discussion. If anybody wants to expose a PoV, please answer this issue!
from do.
If it supports this set of API then
do.Provide(nil, config) do.Provide(nil, datasource) do.Provide(nil, db)
can be writtern as
` do.Provide(config)
do.Provide(datasource)
do.Provide(db)`
it's much more clean
For API compatiable , we can use a new method Register
` do.Register(config)
do.Register(datasource)
do.Register(db)`
if it's ok, I would like raise a PR for this change
thank you!
from do.
Thanks for your suggestion, but I'm not sure we will add these shortcuts to the repository.
Using default injectors is basically a bad idea since it makes your code very hard to test. Adding 18 more helpers without the
i *do.Injector
argument seems excessive to me.Anyway, you can use a simple alias in your projects:
// utils/do.go func Provide(provider do.Provider[T]) { return do.Provide(nil, provider) }I keep this issue open for further discussion. If anybody wants to expose a PoV, please answer this issue!
Using default injectors is basically a bad idea since it makes your code very hard to test
Agree with you about this point. in fact I think about this issue. right now for me I just use the DefaultInjector directly for unit test. From the respect of API user he need to know the detail design of the library, if he want to write clean code.
another benefit of Method aliases is that we dont need to pass(or keep/define) the variable around in the project. I can get it just when I want.
might be a global function is better than a global variable.
change
var DefaultInjector = New()
to
func DefaultInjector() *Injector {}
from do.
Closing, since it has been added to the project under do.DefaultInjector
from do.
Related Issues (20)
- Anonymous Invocation HOT 9
- Possible use of closed services in main() on shutdown HOT 2
- Invoke multiple services satisfying the interface HOT 2
- Is it true that this library doesn't use the reflection package? You lied. HOT 6
- Proposal: do.Shutdown returning shutdown time ? HOT 1
- Proposal: allow multiple implementation for the same interface and being able to return all them HOT 6
- Data race when invoking services after shutdown HOT 1
- Warm up the container HOT 1
- proposal: Add factory provide mode HOT 1
- How to pass structs as inputs for those services HOT 1
- Is there an equivalent to dig.As() ? HOT 1
- shutdown all services even on error HOT 3
- Data race: unsynchronized read of `Injector.services` in `serviceNotFound` HOT 3
- Create application templates
- Debug: Web UI for listing scopes, services and dependencies HOT 1
- Add support of Value Groups HOT 5
- Troubleshooting: flamegraph of service invocation
- v2: Feature Request - expose a method for add lifecycle hook HOT 2
- How can I InvokeNamed T to any HOT 7
- V2 Feature Request: add lifecycle interface support HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from do.