Giter Site home page Giter Site logo

Comments (4)

samber avatar samber commented on July 20, 2024 1

Thanks for your suggestion, but I'm not sure we will add these shortcuts to the repository.

Using default injectors is basically a bad idea since it makes your code very hard to test. Adding 18 more helpers without the i *do.Injector argument seems excessive to me.

Anyway, you can use a simple alias in your projects:

// utils/do.go
func Provide(provider do.Provider[T]) {
    return do.Provide(nil, provider)
}

I keep this issue open for further discussion. If anybody wants to expose a PoV, please answer this issue!

from do.

kcmvp avatar kcmvp commented on July 20, 2024

If it supports this set of API then

do.Provide(nil, config) do.Provide(nil, datasource) do.Provide(nil, db)

can be writtern as

` do.Provide(config)

do.Provide(datasource)

do.Provide(db)`

it's much more clean

For API compatiable , we can use a new method Register

` do.Register(config)

do.Register(datasource)

do.Register(db)`

if it's ok, I would like raise a PR for this change
thank you!

from do.

kcmvp avatar kcmvp commented on July 20, 2024

Thanks for your suggestion, but I'm not sure we will add these shortcuts to the repository.

Using default injectors is basically a bad idea since it makes your code very hard to test. Adding 18 more helpers without the i *do.Injector argument seems excessive to me.

Anyway, you can use a simple alias in your projects:

// utils/do.go
func Provide(provider do.Provider[T]) {
    return do.Provide(nil, provider)
}

I keep this issue open for further discussion. If anybody wants to expose a PoV, please answer this issue!

Using default injectors is basically a bad idea since it makes your code very hard to test

Agree with you about this point. in fact I think about this issue. right now for me I just use the DefaultInjector directly for unit test. From the respect of API user he need to know the detail design of the library, if he want to write clean code.

another benefit of Method aliases is that we dont need to pass(or keep/define) the variable around in the project. I can get it just when I want.

might be a global function is better than a global variable.

change
var DefaultInjector = New()
to

func DefaultInjector() *Injector {}

from do.

samber avatar samber commented on July 20, 2024

Closing, since it has been added to the project under do.DefaultInjector

from do.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.