samebchase/hash-set

An implementation of a hash-set.

hash-set's Issues

Remove optima dependency

Optima is listed as a dependency in the asd file, but it doesn't (seem) to appear in the code at all.

hs-equal return t forever

function hs-equal will always return t because (progn ...) will return last expression.

Also, I notice you use dohashset macro in function hs-equal. I expand it with the expression in hs-equal:

(Block Nil
  (Hs-Map
   (Lambda (Elt)
     (Tagbody (Unless (Hs-Memberp Hs-B Elt) (Return Nil))))
   Hs-A)
  Nil)

because dohashset is not be given &optional result, so no matter the result of (hs-memberp hs-b elt), this block will always return nil.

Other test functions

Are there reasons to use equal as the test function, rather than providing the user with a choice?