samvelraja/google-maps-addon

Simple Wrapper around google maps for simpler ember addon usage

google-maps-addon's Issues

Include google maps SDK from addon

Currently the user has to inject the google maps SDK manually before using this addon. It would be great if it could be handled by the addon. In my project I'm using the following helper that I borrowed from some other ember google maps addon:

import Ember from 'ember';

const API_KEY = 'xxxxxxxxtheapikeyxxxxxx';
const LIBRARIES = ['drawing'];

var promise;

/**
 * Loads the google map SDK
 *
 * @return {Ember.RSVP.Promise}
 */
export function loadGoogleMaps(resolveWith) {
  if (window.google && window.google.maps) {
    return Ember.RSVP.resolve(resolveWith);
  }

  if (promise) {
    return promise;
  }

  var src = `https://maps.googleapis.com/maps/api/js?key=${API_KEY}&libraries=${LIBRARIES.join(",")}`;

  return promise = new Ember.RSVP.Promise(function (resolve, reject) {
    window.__emberGoogleMapLoaded__ = Ember.run.bind(function () {
      promise = null;
      window.__emberGoogleMapLoaded__ = null;
      resolve(resolveWith);
    });

    Ember.$.getScript(src + '&callback=__emberGoogleMapLoaded__').fail(function (jqXhr) {
      promise = null;
      window.__emberGoogleMapLoaded__ = null;
      reject(jqXhr);
    });
  });
}

export default Ember.Helper.helper(loadGoogleMaps);

Become owner

Hi,

I would love to help out with this repo and addon. What do you think about making me an owner/contributor as well so we can iterate quickly?

Polygon support

Adding polygons the same way we add circles, rectangles and infowindows seems like a no brainer. If I get some time today I might make a PR for it.

Having the milestones for adding additional functionalities

@erkie your thoughts?

Republish this new package on npm.

Republish this new package on npm, becouse when i run "ember install google-maps-addon" then install old packages. (for new I must run 'ember install ember install https://github.com/SamvelRaja/google-maps-addon')

Race condition when adding and removing shapes quickly

If a shape is added, then removed in a quick succession (I think within the limit for the adding options.timeout ~10ms), a shape will linger on the screen.

Upgrade ember-cli-version etc

@SamvelRaja I noticed the ember-cli-version and some other dependencies are a bit out of date. Do you see any downsides to upgrading them?

Adding `mapOptions` has observable creates problem in callback hooks

Since the mapOptions is an observable property, when we use the addon in an component, this forces us to create the mapOptions object has mutable object to handle the CB function, therefore, any changes happened in the component property itself creates the mapOptions to update.

say,
converting the mapMessage from mousemove to

mouseout triggers back the the component to re-render

DEMO

Must find a fix ASAP.

One thought is to move-out the CB properties out of mapOptions and providing them as seperate options.

Goal, should not revert back the observer since it is a good enhancement.

@erkie your thoughts are welcome.

Addon improvement and glitches

• zoom must be handled, padding string in zoom throwing error
• Toggler for Zoom contol and scale control in map
• Default map view