Giter Site home page Giter Site logo

generator-aws-lambda's Introduction

generator-aws-lambda's People

Contributors

samverschueren avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

generator-aws-lambda's Issues

Outdated dependencies in generator

After running the generator and building the lambda, there are several issues which prevent npm build to create a deployment package.

Following packages needs to be updated due to ava:

  • typescript
  • @types/node

The test package has a typescript error as well.

Add option for tests

If the question is answered positive, everything should be added for easy test writing.

Refactor zip task

The zip task is not working properly anymore. Since npm@3, all the packages are deduplicated. This makes ignoring the devDependencies not really intelligent. Better would be to create a temp directory, copy all the js files + license + package.json and run npm install --production. Zip everything inside that temp directory.

Remove aws-sdk

aws-sdk is globally available and shouldn't zipped. The module is > 3 MB so this will reduce the size of the uploaded code.

Issue when installing one of the extra packages

For instance, when selecting dynongo in the last question, the package.json file looks like this.

  "dependencies": {
    "bragg": "^0.2.0",
    "bragg-router": "^0.2.0",
    "bragg-env": "^0.2.0",
    "bragg-route-invoke": "^0.1.0",
,
    "dynongo": "^0.6.0"
  },

Don't require github username

While I see that you're using the username as a convenience function to set the name and email address in the package.json, I don't think it should be mandatory; like if someone doesn't enter it offer the option to enter the name and email manually. In my case my github account is completely unrelated to the company I'm doing work for, so I have to hop into the package.json and change it manually negating the convenience factor anyways.

I know it's a minor quibble, but it almost stopped me from using your generator as I immediately had to pause and jump into the source code to see why this module I just downloaded wants to know details about me and what is it going to do with them.

Is it ok to ignore license files?

To keep the zip file as small as possible, all the LICENSE files or ignored and are not copied to the zip file. Is this ok to do or not? Probably this isn't and the licenses should be copied to the zip as well.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.