sancane/precis

Rust implementation of PRECIS Framework: Preparation, Enforcement, and Comparison of Internationalized Strings in Application Protocols

precis's Issues

Further optimize performance for precis-profiles::common::normalization_form_nfkc

According to the comment for precis-profiles::common::normalization_form_nfkc, unicode-normalization::is_nfkc is called in order to try to "save memory allocations" at the cost of making the function "a bit less efficient due to the extra iteration over the string" when the string is not normalized. unicode-normalization::is_nfkc internally might rely on memory allocations though. It would be nice if unicode-normalization::is_nfkc_quick were used instead. A similar argument applies to precis-profiles::common::normalization_form_nfc.

I don't have an opinion on what to do in the event IsNormalized::Maybe is returned. Specifically, I don't care if normalization is done then or one uses unicode-normalization::is_nfkc to definitively check.

Update to Unicode 15

Is there any plan to update to Unicode 15? Related to this, does it matter that precis-core uses a different version than precis-profiles? Seeing how precis-profiles relies on precis-core, doesn't that mean they should be based on the same version?

Re-export `precis-core` in `precis-profiles`

When types or traits of dependencies are part of the public API for a crate, it's common for the dependency itself or at least the used types/traits in the dependency to be re-exported. There are a lot of resources that go over this, but here is one.

Admittedly one of the main reasons for this is to allow downstream code to depend on a different version of the dependency which seems highly unlikely for precis-core; however it still does make it ever so slightly more convenient since downstream code won't even need to add a dependency to precis-core. precis-profiles is essentially useless by itself; so it will almost always be the case that downstream code will need to add a dependency to precis-core manually.

Would it be possible to add

pub use precis_core;

to precis-profiles?