sanctuary-js/sanctuary-scripts

Shell scripts used in multiple Sanctuary projects

sanctuary-scripts's Issues

lint-readme: insert semicolons more discerningly

The script (see below) that rewrites code blocks for linting should be smarter about inserting semicolons, so that the linter will not complain about misplaced semicolons.

sanctuary-scripts/bin/lint-readme

Lines 16 to 41 in ce8733d

	rewrite() {
	local state=
	local line
	while IFS='' read -r line ; do
	local a="${line:0:1}"
	local b="${line:1:1}"
	local z="${line: -1}"
	if [[ $a$b == '> ' ]] ; then
	printf '\n%s' "${line:2}"
	state=input
	elif [[ -n $state && $a$b == '. ' ]] ; then
	printf '\n%s' "${line:2}"
	elif [[ $state == input && $a$z == '{}' ]] ; then
	printf ';\n%s' "($line)"
	state=output
	elif [[ $state == input ]] ; then
	printf ';\n%s' "$line"
	state=output
	elif [[ $state == output ]] ; then
	printf ';\n%s' "$line"
	state=
	else
	printf '\n%s' "$line"
	fi
	done
	}

See Avaq/permissionary#5 for discussion leading up to this.

prepublish script modifies file permissions

https://github.com/sanctuary-js/sanctuary-scripts/blob/v1.2.0/bin/prepublish#L22-L26:

for file in "${files[@]}" $(find test -name '*.js' | sort) ; do
  sed "s/ version = '.*';/ version = '$VERSION';/" "$file" >"$file.updated"
  mv -- "$file.updated" "$file"
  git add -- "$file"
done

This code can also modify line endings, as davidchambers/doctest@03e2852 demonstrates.

Let's remove this troublesome code. Projects which need this functionality can include a similar snippet in scripts/prepublish.

lint-commit-messages does not work by default on Travis CI

Travis CI only checks out the feature branch, so git log --no-merges --format=%s master.. returns no results.

I see two possible solutions:

• document Travis CI configuration for checking out the default branch; or
• compare to the remote's default branch rather than to the local repository's default branch.

Mark mocha and nyc as optional dependencies

A breaking change that makes so users have to manually install mocha and nyc. The reasoning is taken from fluture-js/fluture-template#1 (comment).