sandromancuso/testing_legacy_code

Exercises to unit test legacy code

Testing legacy code: Hard-wired dependencies

Code related to my Testing legacy code: Hard-wired dependencies blog post

What is it about?

Provides an example of existing code that needs to be unit tested. But there is one rule:

We can't change any existing code if not covered by tests. The only exception is if we need to change the code to add unit tests, but in this case, just automated refactorings (via IDE) are allowed.

Although this is a very small piece of code, it has a lot of the problems that we find in legacy code.

Details

If you want to give it a go, the starting point is TripService_Original.java. Try unit testing it following the rule above.

My solution was TripServiceTest.java and TripSerivce.java

testing_legacy_code's Issues

Not the same as during GeeCon

hi

I attended your talk during GeeCon i really liked it. I wanted to use this project as a reference on refactoring legacy code but it seems that:

1. the solution here (https://github.com/sandromancuso/testing_legacy_code/blob/master/src/main/java/org/craftedsw/harddependencies/trip/TripService.java) is not the same as to the one you showed during your talk (asfair at GeeCon you were mocking TripDao and inject that mock into TripService in unit tests)
2. I wish the commit history here would reflect all single steps you did to refactor the code - just like you did during your talk.