sandstorm/crudforms

Extensible CRUD generator for Flow and Neos.

crudforms's Issues

BUG: packageKey dont show up in generateCrudController in console output

Description

Currenty when kickstart the needed files it doesent show the $packageKey in the generateCrudController method.

Screenshot

This is caused by a / which is in the getNamespaceBaseDirectory() method:

CrudForms/Classes/Command/CrudGeneratorService.php

Line 151 in fe9499f

return Files::getNormalizedPath($package->getPackagePath() . '/Classes/');

When removing the / the output looks as i would expect it:

I suspect the reason for this is that there is already a / here. And therefore it could not resolve the path correctly.

CrudForms/Classes/Command/CrudGeneratorService.php

Lines 137 to 139 in fe9499f

	$this->generatedFiles[] = 'Created .../' . $relativeTargetPathAndFilename;
	} else {
	$this->generatedFiles[] = 'Omitted .../' . $relativeTargetPathAndFilename;

Routing for generated controller/action

Hey,

just started to play with this package. It seemed to work in the first place. I tried to create a new "element" and it failed with "Route not setup properly".

Which additional routes are required?

Thanks :-)

FEATURE: Add separate templates for autogenerated fluid files

Would be great to have separate template files for Neos / BS4, which would make the generated fluid templates usable out of the box.

Eventually makes an optional parameter for the commandController necessary.

FEATURE: make form field required in CrudForms\FormField annotation

Description

Currently there is no possibility to set a form field to Required from within the package. It is possible to add the field in the model with the NotEmpty validator from Flow:

/**
 * @Flow\Validate(type="NotEmpty")
 */

However, this does not look really nice afterwards for the editor:

My Idea

What I was thinking about would be if I could set my field in the model to required directly in the @CrudForms annotation:

/**
 * @CrudForms\FormField(label="Note Title", required=true)
 * @var string
 */
protected $noteTitle;

Then we could add an if condition to the respective editors (/Sandstorm.CrudForms/Resources/Private/Partials/CrudForms/Helpers/Editor). And if the required option is set to true, a hint message is displayed in the backend.

I'm still thinking about how to implement this in the most useful way, or if I might have to implement it differently. If you have feedback, I'm happy about it.

Fixture class breaks functional tests

Running functional tests breaks in the test compile step with:

[Semantical Error] The annotation "@Flow\CompileStatic" in method Sandstorm\CrudForms\Tests\Functional\Fixtures\Controller\AddressController::getEntityClassNameToRepositoryClassNameMapping() was never imported.
Did you maybe forget to add a "use" statement for this annotation?

Fixture Controller breaks functional tests

Running functional tests breaks in the test compile step with:

[Semantical Error] The annotation "@Flow\CompileStatic" in method Sandstorm\CrudForms\Tests\Functional\Fixtures\Controller\AddressController::getEntityClassNameToRepositoryClassNameMapping() was never imported.
Did you maybe forget to add a "use" statement for this annotation?