sanogueralorenzo/android-kotlin-clean-architecture

Android Sample Clean Architecture App written in Kotlin

android-kotlin-clean-architecture's Issues

how navigation works

I don't understand your package name constant but, how setClassName works for passing postlist to postdetail? When I use your navigation, I have an ActivityNotFoundException with have you declared this activity in your AndroidManifest.xml?

Gradle KTS Build Files warning

Hi, just pulled project and got warning from Android Studio 3.5

Build error

C:\Android-Kotlin-MVI-CleanArchitecture\build\build-attribution\androidGradlePluginAttributionData: The process cannot access the file because it is being used by another process.

I get this error when I try to run the app on the master branch.

Kotlin clean architecture

Question about injectFeature function

Hi! I tried to use Koin library with multi-feature modules, however, I don't know how to load koin modules properly from each features. Finally, I saw your blog post and get how to load koin modules in feature. The differences is "injectFeature"(loadFeature by lazy). I tried to load modules directly

It works as I expected,but I don't know why it is working. So, could you explain for this?

This Library

// Application
class App: Application() {
    override fun onCreate() {
        super.onCreate()

        startKoin { androidContext(this) } // it seems deprecated...
    }
}

// Modules.kt
fun injectFeature() = loadFeature

private val loadFeature by lazy {
    loadKoinModules(
        viewModelModule,
        useCaseModule,
        repositoryModule,
        dataSourceModule,
        networkModule,
        cacheModule
    )
}

// in Activity
onCreate() {
	super.onCreate()
	injectFeature()
}

What I tried

// Application
class App: Application() {
    override fun onCreate() {
        super.onCreate()

        startKoin(this, listOf(networkModule, analyticsModule))
    }
}

// in Activity One
onCreate() {
	super.onCreate()
	loadKoinModules(listOf(oneViewModelModule))
}
// in Activity Two
onCreate() {
	super.onCreate()
	loadKoinModules(listOf(twoViewModelModule))
}

it works, however, it throws Exception like this when calling loadKoinModules again...
org.koin.error.BeanOverrideException: Try to override definition with Factory [name='OneViewModel...

Cause: DefaultClassLoaderScope ... must be locked before it can be used to compute a classpath!

After updating gradle.property for the property org.gradle.configureondemand=true, it generate below error.

Cause: org.gradle.api.internal.initialization.DefaultClassLoaderScope@2c3c5fa9 must be locked before it can be used to compute a classpath!

It works when setting the value to false. In that case, the purpose for the property for the multimodule project won't get solved right?

I'm using Kotlin DSL with the same gradle wrapper version from the repository.
Also changed the java version from 8, 11 & 16 still it has the same error.

If it works with value true then how to resolve the above issue?

using .subscribeOn() and .observeOn() with the same thread

I didn't understand why you switched thread from Schedulers.io() to Schedulers.io().

here - https://github.com/sanogueralorenzo/Android-Kotlin-Clean-Architecture/blob/master/presentation/src/main/java/com/sanogueralorenzo/presentation/userdetails/UserDetailsViewModel.kt.

here - https://github.com/sanogueralorenzo/Android-Kotlin-Clean-Architecture/blob/master/presentation/src/main/java/com/sanogueralorenzo/presentation/postlist/PostListViewModel.kt

and here - https://github.com/sanogueralorenzo/Android-Kotlin-Clean-Architecture/blob/master/presentation/src/main/java/com/sanogueralorenzo/presentation/postdetails/PostDetailsViewModel.kt

You just can omit .observeOn() operator which switch to the same thread and execution will continue in thread that you specify in subscribeOn(). (proof - https://proandroiddev.com/understanding-rxjava-subscribeon-and-observeon-744b0c6a41ea)

erro code

how to get code of error response

.subscribe(
                {
                    financialResult.setSuccess(it)
                    setLoading(false, "financialResult")
                },
                {

                    financialResult.setError**(it.code)**
                    setLoading(false, "financialResult")
                }
            )

Instrumentation tests in Feature modules

Expected:

• define Koin application and mock dependencies in test's @Before

What's happening:

• Feature module's injectFeature() is crashing the test because of duplicate dependencies

I'm curious if you've faced this issue and how you've solved it. Thanks!

Build time error