sansegotek/dfkquestrunner

Keep your DeFi Kingdoms heroes questing without breaking a sweat.

dfkquestrunner's Issues

"Error starting quest - this will be retried next polling interval" infinite loop when adding 15+ heroes

Adding more then 15 heroIDs to the Fishing nonProfessionHeroes section of the config leads to a infinite loop of the error "Error starting quest - this will be retried next polling interval" when running the tool. This doesn't seem to happen for any other quest I've been running with the same amount of heroes.

https://i.gyazo.com/124509083626c18acd6fd65a8dea9f71.png

• I verified each individual heroID to make sure they were fully correct and correspond with the wallet being used (19 heroes total)
• I swapped the order of the heroIDs to make sure there wasn't a bugged hero somewhere in the order
• I removed each individual heroIDs until only 10-15 remained, only then did my quests start going through
• I verified all heroes apart of the nonProfessionHeroes section were not listed for sale or for hire in the tavern

I'm not entirely sure if it's just something on my end and how to go about troubleshooting/resolving it without any error logs, let me know if there's anything else I can do!

Validate configuration

Make sure all configured heroes belong to the configured wallet address
Make sure no duplicate hero IDs

Tidy up output

Use newlines instead of console.log()
Maybe use colours to make rewards etc stand out more
Generally make the layout look easier to read

RFC: UI for DFKQuestRunner

Overview

@SansegoTek kicked of DFKQuestRunner, a tool that runs DFK quests for you without needing to log in and do it yourself. As of right now, the tool is only available to use by anyone with a little bit of developer experience.

It would be ideal to create a UI on top of DFKQuestRunner that would allow many to take advantage of what it has to offer. This RFC is a high-level proposal for how this can be achieved. Any and all feedback is welcome.

The goals from the UI would be to have the following:

• Connect to site through MM wallet to allow access to API
• Display heroes and select which ones you'd like to run quests with
• Run optimal quests based on hero professions
• Provide a way to run quests however you want
• Display state to keep user up to date on progress

Proposal

NextJS is the leading framework for full-stack React apps. This tool is already built with node so it won't be too hard to switch most of it over.

With React, we can create some easy-to-use hooks that can be passed around throughout the app that also manage things that we need like loading states.

For example, the hook would be called useRunner oruseQuests if we want to be more specific and intentional about the API we're using.

Consider the following code:

  import React from 'react'
  import { useQuest } from '../hooks/useQuest'

function QuestRunner() {
  const { startQuest } = useQuest()

  return (
    <>
      // Quest Runner UI here
       <button onPress={() => startQuest(FISHING_QUEST_ID_HERE)}>Fishing Quest</button>
    </>
  )
}

I think it'd be better to have a UI for selecting and managing the configuration of the quest runner, but the point of this example code was to show how the hooks would be used.

We'd need state management to handle setting up the configuration of using the quest runner, we don't need a library or anything. Could probably get far enough with useReducer. Here are some of the things we'd have to manage as far as state, this reflects what's in the current config file for DFKrunner:

• Quests
• Profession Heroes
• Non Profession Heroes

Styling

Not sure how people feel here, perhaps we can stick to Tailwind (I've never used Tailwind)

Note

Not sure how signing into Meta Mask would work here, someone should definitely speak on that if they're familiar. Perhaps we can make a kind of for local usage until we have that figured out. Let me know if you'd like for me to elaborate on that.

How to provide feedback

This RFC is open to feedback, let me know if I've forgotten anything. If we come to an agreement on things, I wouldn't mind kicking off the foundation.

Added Rewards

Added some missing rewards at the bottom:
"0xAC5c49Ff7E813dE1947DC74bbb1720c353079ac9": "Bluestem",
"0x19B9F05cdE7A61ab7aae5b0ed91aA62FF51CF881": "Spiderfruit",
"0xc0214b37FCD01511E6283Af5423CF24C96BB9808": "Milkweed",
"0x72Cb10C6bfA5624dD07Ef608027E366bd690048F": "Gold",

rewards.zip

update in the works?

im going to assume most of the issues i am having currently are due to Harmony networt,
main issue being that the script recognizes that my hero is ready to quest but cannot initiate the questing, same goes when a quest is complete it recognizes that it is complete but cannot actually complete.

i did abit of testing since the network has been somewhat stable by running the script which should initiate my hero questing(which it hasnt been) then manually trying it through the game itself and being able to instantly quest. Same going for completing i run the script prior to completion it recognizes that quest is complete but cant complete it, i then go in game and am instantly able to complete the quest.

Very much appreciate you guys for open sourcing this!

"missing revert data in call exception"

This may only be an issue on the Pokt network, but I believe I've seen it on main.

An error occured. Will attempt to retry in 180 seconds... Error: Error: missing revert data in call exception (error={"reason":"processing response error","code":"SERVER_ERROR","body":"{\"jsonrpc\":\"2.0\",\"id\":144,\"error\":{\"message\":\"Relay attempts exhausted\",\"code\":-32050}}","error":{"code":-32050},"requestBody":"{\"method\":\"eth_call\",\"params\":[{\"to\":\"0x5100bd31b822371108a0f63dcfb6594b9919eaf4\",\"data\":\"0xdf52458a000000000000000000000000000000000000000000000000000000000000c823\"},\"latest\"],\"id\":144,\"jsonrpc\":\"2.0\"}","requestMethod":"POST","url":"https://harmony-0-rpc.gateway.pokt.network"}, data="0x", code=CALL_EXCEPTION, version=providers/5.5.1)
    at Logger.makeError (/Users/pete/Work/DFKQuestRunner/node_modules/@ethersproject/logger/lib/index.js:199:21)
    at Logger.throwError (/Users/pete/Work/DFKQuestRunner/node_modules/@ethersproject/logger/lib/index.js:208:20)
    at checkError (/Users/pete/Work/DFKQuestRunner/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:76:16)
    at JsonRpcProvider.<anonymous> (/Users/pete/Work/DFKQuestRunner/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:659:47)
    at step (/Users/pete/Work/DFKQuestRunner/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:48:23)
    at Object.throw (/Users/pete/Work/DFKQuestRunner/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:29:53)
    at rejected (/Users/pete/Work/DFKQuestRunner/node_modules/@ethersproject/providers/lib/json-rpc-provider.js:21:65)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  reason: 'missing revert data in call exception',
  code: 'CALL_EXCEPTION',
  error: Error: processing response error (body="{\"jsonrpc\":\"2.0\",\"id\":144,\"error\":{\"message\":\"Relay attempts exhausted\",\"code\":-32050}}", error={"code":-32050}, requestBody="{\"method\":\"eth_call\",\"params\":[{\"to\":\"0x5100bd31b822371108a0f63dcfb6594b9919eaf4\",\"data\":\"0xdf52458a000000000000000000000000000000000000000000000000000000000000c823\"},\"latest\"],\"id\":144,\"jsonrpc\":\"2.0\"}", requestMethod="POST", url="https://harmony-0-rpc.gateway.pokt.network", code=SERVER_ERROR, version=web/5.5.1)

Times displaying with single-digit hours/minutes/seconds

e.g. "20:0:41". fix up so they use 2 digits always

Negative stamina for heroes after completing quest

Hey, been using the bot and creating mine, I get negative stamina on heroes when they complete quest... any idea why ? :( I have -98 stamina on my hero now and I have to wait until he is full again !

Thanks
Regards

Always include the quest name in logging

Currently when completing or waiting for a quest to finish, the logging doesn't include the quest name. Make sure it's included

Remove the display "Nothing :(" from rewards

Displaying "Nothing :(" for failed quests doesn't add anything, it just clutters the output. Remove it

Automatically assign heroes quests

Automatically assign heroes to the best quests for them, based on profession and stats

"quest is not ready to start"

I don't get errors, but I don't see it working either.

No matter how I config the heroes, I get these messages, no matter how much stamina by heroes have:

Non-professional Fishing quest is not ready to start.
Non-professional Foraging quest is not ready to start.

Break out XP, Skill, Rewards for each individual hero

Currently, all rewards are added together and displayed as one, regardless of which hero gained them. it would be better to list out what each individual hero gained from the quest

Get the due start time for quests that haven't yet hit the stamina requirements

There are 2 commented out lines in completeQuest that should pull back the time when a hero's stamina will be full. This seemed to be causing an error, work out why

Use metamask signing to avoid using the primary key

Need to look into this