Giter Site home page Giter Site logo

Comments (6)

santilland avatar santilland commented on August 14, 2024

Hello sfalmo, thank you for spotting this. I guess considering this the best/only? approach would be to have a dummy canvas to check if the extension works. As far as i can see only Opera Android (and maybe Firefox for Android) does not support OES_texture_float.
If browser support is more important then performance i would generally go with disabling webgl. I think this is quite a niche issue, is this affecting your work in some way?

from plotty.

sfalmo avatar sfalmo commented on August 14, 2024

Hello santilland, thank you for your feedback.
I also thought that this should not affect many devices. However, I am a bit puzzled that I can reproduce this on some browsers that should support this feature according to MDN. For example, Chrome 90 on a Samsung Tablet with Android 8.1.0 or Safari on an iPhone 8. If I explicitly set useWebGL = false, everything works correctly.
I think that for my purpose, no WebGL would be ok. But for others, this issue might lead to some confusion, especially since useWebGL = true is default. Especially if they rely on WebGL in case of big datasets.

Nevertheless, this could probably be avoided by going with the dummy canvas approach which should be simple to implement.

from plotty.

santilland avatar santilland commented on August 14, 2024

I think d290606 should do the trick?
Don't really have any device to test, do you have any by chance? If this solves your issue i would include it and create a release with the two fixes.

from plotty.

sfalmo avatar sfalmo commented on August 14, 2024

That should work in my opinion. I can test this on Thursday and will report back then.

from plotty.

sfalmo avatar sfalmo commented on August 14, 2024

I could test this patch now and it works! Thanks for your effort.

from plotty.

santilland avatar santilland commented on August 14, 2024

Great to hear! made the release now. Will close the ticket.

from plotty.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.