sap-archive/fedem-gui

Graphical user interface for FEDEM

fedem-gui's Issues

Unbalanced braces

At https://github.com/SAP/fedem-gui/blob/main/src/vpmUI/vpmUITopLevels/vpmUIQtTopLevels/FuiQtProperties.C#L491 it shall read

  }
#endif

instead of

#endif
  }

How to Set environment variable CMAKE_MODULES?

Hi,

I am trying to build the gui under win 10 with vs 2022 and got the error when run cmake:

-- Generating build project for D:/FEDEM/fedem-gui-main -- ERROR : Missing path to FedemConfig.cmake CMake Error at CMakeLists.txt:45 (message): Set environment variable CMAKE_MODULES and try again

I can't find file FedemConfig.cmake.
how to set this and to what value?

Cheers

John

Missing header (std::ostream_iterator)

#include <iterator> at https://github.com/SAP/fedem-gui/blob/main/src/vpmApp/vpmAppUAMap/FapUAItemsListView.C#L9

Crash when Coin library is used

When Coin is found the GUI crashes during the spashscreen, because FUI is initialized here, and then FdDB is asked to intialized also here.

Unfortunately, Fui::getMainWindow() cannot be called until Fui::start() is called at https://github.com/SAP/fedem-gui/blob/main/src/vpm_main.C#L244

Thus a NULL is passed to SoQt::init(), so the program crashes.

Typo on CMake

FFuQtBUtton -> FFuQtButton at https://github.com/SAP/fedem-gui/blob/main/src/FFuLib/FFuQtComponents/CMakeLists.txt#L12

Missing dependency

FFaOperation shall be added as dependency at https://github.com/SAP/fedem-gui/blob/main/src/vpmApp/vpmAppUAMap/CMakeLists.txt#L89 (I added it at the end of the list).

Otherwise a bunch of undefined referenced will be thrown:

/usr/bin/ld: vpmApp/vpmAppUAMap/libvpmAppUAMap.a(FapUARDBSelector.C.o): in function `FapUARDBSelector::onResultApplied()':
FapUARDBSelector.C:(.text+0x28c0): undefined reference to `FFaOpUtils::findOpers(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)'
/usr/bin/ld: FapUARDBSelector.C:(.text+0x2c70): undefined reference to `FFaOpUtils::getDefaultOper(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)'
/usr/bin/ld: vpmApp/vpmAppUAMap/libvpmAppUAMap.a(FapUACurveAxisDefinition.C.o): in function `FapUACurveAxisDefinition::setAxisData(FFaResultDescription const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
FapUACurveAxisDefinition.C:(.text+0x71c): undefined reference to `FFaOpUtils::findOpers(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)'
/usr/bin/ld: vpmApp/vpmAppUAMap/libvpmAppUAMap.a(FapUAAnimationDefine.C.o): in function `FapUAAnimationDefine::getDBValues(FFuaUIValues*)':
FapUAAnimationDefine.C:(.text+0x4f9e): undefined reference to `FFaOpUtils::findOpers(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)'
/usr/bin/ld: FapUAAnimationDefine.C:(.text+0x5e3c): undefined reference to `FFaOpUtils::findOpers(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)'
/usr/bin/ld: FapUAAnimationDefine.C:(.text+0x6cfc): undefined reference to `FFaOpUtils::getDefaultOper(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)'
/usr/bin/ld: vpmApp/vpmAppUAMap/libvpmAppUAMap.a(FapUAResultListView.C.o): in function `FapUAResultListView::dropItems(int, bool, void*)':
FapUAResultListView.C:(.text+0x55f7): undefined reference to `FFaOpUtils::getDefaultOper(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)'
/usr/bin/ld: fedem-foundation/FFpLib/FFpCurveData/libFFpCurveData.a(FFpCurve.C.o): in function `FFpCurve::findVarRefsAndOpers(FFrExtractor*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >&)':
FFpCurve.C:(.text+0x1f60): undefined reference to `FFaOpUtils::findOpers(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)'
/usr/bin/ld: vpmApp/vpmAppDisplay/libvpmAppDisplay.a(FapAnimationCreator.C.o): in function `FapAnimationCreator::initFringeReading(FmPart*, FFrExtractor*, FmAnimation*, std::vector<int, std::allocator<int> > const*)':
FapAnimationCreator.C:(.text+0x1b26): undefined reference to `FFaOpUtils::findOpers(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, bool)'
collect2: error: ld returned 1 exit status

Curve plotting does not work in R8.0.0

The property editor panel is empty for Graph and Curve objects, and the "Show Graph" menu item is always grey/insensitive.

Missing header (strrchr)

#include <cstring> at https://github.com/SAP/fedem-gui/blob/main/src/vpm_main.C#L27

Regression introduced at 4687d6561164acef7cbd0cf170b040f9d101c48b

#include "FFlLib/FFlElementBase.H" cannot be removed or else

/home/pepe/CoreMarine/exmar/fedem/fedem-gui/src/vpmApp/vpmAppUAMap/FapUARDBSelector.C:194:52: error: no matching function for call to ‘find(std::vector<std::__cxx11::basic_string<char> >::iterator, std::vector<std::__cxx11::basic_string<char> >::iterator, const std::string&)’
  194 |   std::vector<std::string>::iterator it = std::find(allOpers.begin(), allOpers.end(),
      |                                           ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  195 |                                                     myCurve->getResultOper(myAxis));
      |                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/c++/13.2.1/bits/locale_facets.h:48,
                 from /usr/include/c++/13.2.1/bits/basic_ios.h:37,
                 from /usr/include/c++/13.2.1/ios:46,
                 from /usr/include/c++/13.2.1/istream:40,
                 from /usr/include/c++/13.2.1/sstream:40,
                 from /home/pepe/CoreMarine/exmar/fedem/fedem-gui/fedem-mdb/fedem-foundation/src/FFaLib/FFaContainers/FFaField.H:12,
                 from /home/pepe/CoreMarine/exmar/fedem/fedem-gui/fedem-mdb/vpmDB/FmBase.H:21,
                 from /home/pepe/CoreMarine/exmar/fedem/fedem-gui/fedem-mdb/vpmDB/FmModelMemberBase.H:14,
                 from /home/pepe/CoreMarine/exmar/fedem/fedem-gui/fedem-mdb/vpmDB/FmSubAssembly.H:11,
                 from /home/pepe/CoreMarine/exmar/fedem/fedem-gui/src/vpmApp/vpmAppUAMap/FapUARDBSelector.C:17:
/usr/include/c++/13.2.1/bits/streambuf_iterator.h:435:5: note: candidate: ‘template<class _CharT2> typename __gnu_cxx::__enable_if<std::__is_char<_CharT2>::__value, std::istreambuf_iterator<_CharT, std::char_traits<_CharT> > >::__type std::find(istreambuf_iterator<_CharT, char_traits<_CharT> >, istreambuf_iterator<_CharT, char_traits<_CharT> >, const _CharT2&)’
  435 |     find(istreambuf_iterator<_CharT> __first,
      |     ^~~~
/usr/include/c++/13.2.1/bits/streambuf_iterator.h:435:5: note:   template argument deduction/substitution failed:
/home/pepe/CoreMarine/exmar/fedem/fedem-gui/src/vpmApp/vpmAppUAMap/FapUARDBSelector.C:194:52: note:   ‘__gnu_cxx::__normal_iterator<std::__cxx11::basic_string<char>*, std::vector<std::__cxx11::basic_string<char> > >’ is not derived from ‘std::istreambuf_iterator<_CharT, std::char_traits<_CharT> >’
  194 |   std::vector<std::string>::iterator it = std::find(allOpers.begin(), allOpers.end(),
      |                                           ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  195 |                                                     myCurve->getResultOper(myAxis));
      |                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [src/vpmApp/vpmAppUAMap/CMakeFiles/vpmAppUAMap.dir/build.make:440: src/vpmApp/vpmAppUAMap/CMakeFiles/vpmAppUAMap.dir/FapUARDBSelector.C.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2310: src/vpmApp/vpmAppUAMap/CMakeFiles/vpmAppUAMap.dir/all] Error 2

Curve plotting still does not work

After fixing #1 it was revealed that all curves only plot the first point in the graph. Therefore the graph views appear empty. However you can see the first point of the curve if you chose a Symbol in the Appearance tab.

Automatically perform strain gage recovery during solve if strain gage results are used as function arguments

As of now the user has to manually toggle on the "Perform strain rosette recovery during dynamics simulation" for the FE part owing that strain rosette. This is easily forgotten, and instead we get an mis-leading error message from solver that the strain rosette does not exist. This is fine if the strain rosette results are only used for plotting, but if they are also used as function arguments, the recovery must be enabled for the model to be consistent.

[rl-reuse_tool-4] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-4
Explanation: Is it compliant with REUSE rules? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Incorrect default location for model open and save as

When selecting File -> Open... or File Save As... the default location of the file browser that appears is the location of the executable (unless you start Fedem from a console window and cd to the executable location in there first). It should have been the home location of the user profile.

Crash when creating a Generic DB Object

If you select the "Generic DB Object" item in the Mechanism menu, the GUI crashes without any messages.
The same happens in the earlier versions R7.6.3 and R7.6.2 also, but not in the versions prior to that.

Missing header

#include <stddef.h> at https://github.com/SAP/fedem-gui/blob/main/src/FFuLib/FFuLogicButtonGroup.H#L12

NULL is not defined by default

Qt5

Related to #17

Ok, it seems the whole problem on my system is Qt4. Would you be interested on upgrading to Qt5?

False error messages on failure to delete files when doing Save As...

When doing Save As... and the current model already contains some files in its _RDB directory (and/or linkDB), an error message is given to the Output List -> Could not delete <filename> for each one of then. Although these files should not be deleted at this point.