sap-samples/cap-sflight

Using SAP Cloud Application Programming Model and SAP Fiori elements to build a simple travel management app, both with Node.js and Java.

cap-sflight's Issues

When deployment actions will be back?

From your comment in .github/workflows/node.js.yml about "temporarily switch off deployment as it consistently fails" , When deployment actions example will be back? Thank you.

CF DEPLOYMENT NEVER WORKS

app gets deployed to cf but not at all in working conditon : {"statusCode":401,"code":"401","message":"Unauthorized"}
can someone please share why am I getting this error?

Deploy to Kyma - Configuration global.domain

Hello CAP Team,

I've just went through the Deployment to SAP Business Technology Platform - Kyma Runtime. One step that I've struggled with was in the configuration step. Where I'm asked to "Change value of global.domain key to your cluster domain.". As the in the file is:

global:
  domain: <your own domain>

a beginner will have trouble to find it. Because searching for global.domain doesn't give any result. Also a good tip would be that the domain can be found at https://dashboard.kyma.cloud.sap/clusters where the part after https://api. is the value that needs to be inserted:

Best Regards
Gregor

Unauthorized error on BTP/CF

After cf deploy mta_archives/capire.sflight_1.0.0.mtar when I run the service in BTP, and click any entity it gives a 401 Unauthorized error.

401 Unauthorized

Am I missing some details? Kindly advice.

@rbrechter @stewsk

airline pictures are requested from github

Hi colleagues,
the airline pictures are requested from github each time (not within sflight and not cached).
Best Regards
Chr

As this project doesn't provide a standalone approuter you have to subscribe to one of the mentioned services. The cheapest or even free one is the Launchpad Service. You might create a new issue in this project and suggest the addition of a standalone approuter.

    As this project doesn't provide a standalone approuter you have to subscribe to one of the mentioned services. The cheapest or even free one is the Launchpad Service. You might create a new issue in this project and suggest the addition of a standalone approuter.

Originally posted by @gregorwolf in #360 (comment)

Internal Server Error after deployed to HANA DB

dear experts, I tried many times but still have no clue why there is an internal server error issue as screenshot shows.

Once I click "Go" (sorry for Chinese) and the error will come.
The same will come if I click "Create".
I already granted myself the required roles.

[rl-assigned_teams-2] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-assigned_teams-2
Explanation: Does it have an admin team on GitHub? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Comments in json files are not supported and may break tools.

Please remove:

cap-sflight/.vscode/launch.json

Lines 2 to 4 in 908db2d

	// Use IntelliSense to learn about possible attributes.
	// Hover to view descriptions of existing attributes.
	// For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387

CAP SFlight breaks with SAP UI 5 Version 120

When you run SFlight locally or with the current CI you see that UI (tests) don't work anymore. This is due to a bug in UI5 that we can't actively detect as we only have defined a minimum version for UI5. This is OK since we want to always use the latest and greatest. ;)

We should, however, have a regular CI run that would then detect such breakage. ☝🏽

building native image with graalvm ce 21 not working

Hi colleagues,
as already talked to Marc

• building the native image with graalvm ce 17 is working fine
• building the native image with graalvm ce 21 is not working
  Best Regards
  Chr

[rl-reuse_tool-4] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-4
Explanation: Is it compliant with REUSE rules? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Include TypeScript stack (cds-routing-handlers)

It would be nice if there was also TypeScript example using cds-routing-handlers. I imagine it should be a bit similar to the Java one.

[rl-reuse_tool-2] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-reuse_tool-2
Explanation: Does it have LICENSES directory with licenses? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

[rl-assigned_teams-1] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-assigned_teams-1
Explanation: Does it have enough teams on GitHub? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html

Travel Analytics UI freezes upon table selection

1. npm run start
2. Open travel_analytics FE preview
3. In the Bookings Table

• Click on the first-level group header (Airline)
• Click on the second-hierarchy group header (Booking Status)
  -> Observe that the UI becomes unresponsive and an error is thrown

Log-dbg.js:499  2024-01-05 07:49:55.917800 Unexpected element - Error: Unexpected element
    at Object.beforeOverwritePlaceholder (https://ui5.sap.com/1.120.1/resources/sap/ui/core/library-preload.js:2262:1381)
    at c (https://ui5.sap.com/1.120.1/resources/sap/ui/core/library-preload.js:2256:2922)
    at Array.forEach (<anonymous>)
    at l.addElements (https://ui5.sap.com/1.120.1/resources/sap/ui/core/library-preload.js:2256:3588)
    at https://ui5.sap.com/1.120.1/resources/sap/ui/core/library-preload.js:2256:9542 sap.ui.model.odata.v4.ODataModel

A technical error has occurred with the now default SAPUI5 1.95.0

Hello SAP CAP Team,

yesterday SAPUI5 1.95.0 was made the default in the CDN. when Starting the sample app the following error occurs:

A technical error has occurred.
this._oAppComponent.getRootControl(...).getController(...).getPlaceholder is not a function

Best Regards
Gregor

[rl-assigned_teams-3] Violation against OSS Rules of Play

A violation against the OSS Rules of Play has been detected.

Rule ID: rl-assigned_teams-3
Explanation: Does it have enough admins on GitHub? No

Find more information at: https://sap.github.io/fosstars-rating-core/oss_rules_of_play_rating.html